[09:38:05] <font color="#600060">Dominus:</font> Marzo, I didn't notice that the ci-macos does not test the gimp plugin and I haven't build it for a long time. Now I tried and ran into build errors https://pastebin.com/ZcvPP5e5<BR>
[09:39:58] <font color="#005000">Marzo:</font> It is not building as c++14 for whatever reason<BR>
[09:54:04] <font color="#600060">Dominus:</font> huh... if I force c++14 by adding it to the c/cpp/cf/cxxflags (  --std=c++14) it builds but doesn't link with multiple errors https://pastebin.com/49Pk1xA5<BR>
[10:01:07] <font color="#005000">Marzo:</font> You probably also need to add c++14 flags for linker<BR>
[10:04:01] <font color="#600060">Dominus:</font> it's also set for LDFLAGS<BR>
[10:04:23] <font color="#005000">Marzo:</font> Oh, right, I see it<BR>
[10:04:25] <font color="#005000">Marzo:</font> Hm<BR>
[10:05:59] <font color="#005000">Marzo:</font> Try adding a -stdlib=libc++<BR>
[10:06:28] <font color="#005000">Marzo:</font> Hm, wait<BR>
[10:06:39] <font color="#600060">Dominus:</font> ok :)<BR>
[10:07:59] <font color="#005000">Marzo:</font> It is not linking several Exult things<BR>
[10:53:35] <font color="#600060">Dominus:</font> I really don't understand what's happening here. I tried several things now but always end up with this<BR>
[10:58:33] <font color="#0000fc">azeem:</font> I get the following warnings on autoreconf (thought they've been around a long time I guess): http://paste.debian.net/1237452/<BR>
[11:00:52] <font color="#600060">Dominus:</font> yes, I noticed, too that the latest autoreconf is no longer happy with our configure.ac<BR>
[11:02:23] <font color="#0000fc">azeem:</font> I also get linking errors even though configure went through fine: /usr/bin/ld: /tmp/ccA2D2hK.o: undefined reference to symbol '_ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE9_M_appendEPKcm'<BR>
[11:05:32] <font color="#600060">Dominus:</font> linking which part or everywhere?<BR>
[11:06:20] <font color="#0000fc">azeem:</font> I think in mapedit, u7shp, but others as well<BR>
[11:06:35] <font color="#0000fc">azeem:</font> so both libgtk3.0 and libgtk2.0 get dragged in<BR>
[11:06:41] <font color="#0000fc">azeem:</font> maybe a Debian issue then<BR>
[11:07:17] <font color="#0000fc">azeem:</font> ah no, github-action CI also installs both<BR>
[11:07:22] <font color="#0000fc">azeem:</font> let me compare build deps<BR>
[11:09:09] <font color="#0000fc">azeem:</font> /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libexiv2.so.27: error adding symbols: DSO missing from command line<BR>
[11:09:20] <font color="#0000fc">azeem:</font> that's the second error line, which seems important as well :)<BR>
[11:11:11] <font color="#600060">Dominus:</font> bah, I hate missing symbols<BR>
[11:14:46] <font color="#0000fc">azeem:</font> exiv seems to come in via libgimp-dev<BR>
[11:14:55] <font color="#0000fc">azeem:</font> it's not mention in libgimp's .oc<BR>
[11:14:59] <font color="#0000fc">azeem:</font> eh, .pc<BR>
[11:18:43] <font color="#0000fc">azeem:</font> when you make clean, reconfigure and jump into mapedit to make, you'll eventually get a "no rule to make <font color="#0000fc">conf/something:</font>", I wonder whether that could be more friendly, i.e. build the dependencies first<BR>
[11:27:37] <font color="#0000fc">azeem:</font> I've added all the deps from github-action's linux CI as well as the configure opts, and the undefined reference persists<BR>
[11:28:25] <font color="#0000fc">azeem:</font> anybody know what "ubuntu-latest" is exactly?<BR>
[11:29:05] <font color="#0000fc">azeem:</font> probably 20.04<BR>
[11:34:18] <font color="#600060">Dominus:</font> yes https://github.com/actions/virtual-environments<BR>
[11:35:31] <font color="#0000fc">azeem:</font> I get the same issue on Debian stable though<BR>
[11:43:28] <font color="#0000fc">azeem:</font> what's sticks out if I compare the command-lines between gh-actions and debian build is "-Wl,-z,relro -Wl,--as-needed" so I'm trying without that now<BR>
[11:46:27] <font color="#0000fc">azeem:</font> no that's not it either<BR>
[11:46:56] <font color="#0000fc">azeem:</font> those gazillion of GTK/ATK warnings don't help comparing things<BR>
[11:47:32] <font color="#0000fc">azeem:</font> well, glib/atk I guess<BR>
[12:05:40] <font color="#0000fc">azeem:</font> also I wonder why u7shp is being linked by gcc and not g++?<BR>
[12:16:35] <font color="#600060">Dominus:</font> maybe that's why it won't build on macOS?<BR>
[12:18:33] <font color="#600060">Dominus:</font> Marzo, it seems the gimp plugin never built on macOS since you made it a c++ program. first the makefile.am didn't allow it to find the exult includes and then it fails with either c++14 not being defined or if that is with linking failing<BR>
[12:19:08] <font color="#005000">Marzo:</font> Or in linux, as I am investigating it under WSL<BR>
[12:19:23] <font color="#005000">Marzo:</font> It seems it was only building on Windows because it does not use gimptool<BR>
[12:31:01] <font color="#0000fc">azeem:</font> well the linux-ci gh action seems to build fine right?<BR>
[13:16:21] <font color="#0000fc">azeem:</font> I tried with a focal build chroot and I indeed don't see the exiv2 linking error, however, I get a similar error with libstdc++ there<BR>
[13:16:34] <font color="#0000fc">azeem:</font> /usr/bin/ld: /tmp/ccoNBIq1.o: undefined reference to symbol '_ZNSt6localeD1Ev@@GLIBCXX_3.4'<BR>
[13:16:37] <font color="#0000fc">azeem:</font> /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: error adding symbols: DSO missing from command line<BR>
[13:28:02] <font color="#0000fc">azeem:</font> oh<BR>
[13:29:49] <font color="#0000fc">azeem:</font> I have the feeling the build system just doesn't propagate errors correctly, or is github-action supposed to be green in such a case?<BR>
[13:35:01] <font color="#600060">Dominus:</font> I *think* because it is using gimptool the errors don't stop it<BR>
[13:35:25] <font color="#005000">Marzo:</font> I just pushed a fix<BR>
[13:36:17] <font color="#0000fc">azeem:</font> Dominus: yeah exactly, looks like a bug in gimptool<BR>
[13:37:31] <font color="#0000fc">azeem:</font> Marzo: thanks, will try<BR>
[13:37:49] <font color="#005000">Marzo:</font> The fix is to avoid using gimptool for building<BR>
[13:38:04] <font color="#005000">Marzo:</font> And just use it to get include and link flags<BR>
[13:45:04] <font color="#0000fc">azeem:</font> /usr/share/games/exult/bg_{paperdol,mr_faces}.vga are no longer around, is that expected?<BR>
[13:47:36] <font color="#0000fc">azeem:</font> anyway, it builds fine<BR>
[13:47:56] <font color="#0000fc">azeem:</font> now I need to figure out which new data files belong to exult, and which to exult-studio<BR>
[13:48:00] <font color="#0000fc">azeem:</font> but I'll do that later<BR>
[13:49:09] <font color="#005000">Marzo:</font> Dominus: with 0356e19f, build now fails for me :/<BR>
[13:50:27] <font color="#005000">Marzo:</font> Command line shows a -isystem -isystem <font color="#0000fc">path:</font> at the end<BR>
[13:51:06] <font color="#600060">Dominus:</font> come on<BR>
[13:51:45] <font color="#005000">Marzo:</font> Which is what the -I was there for in the first place<BR>
[13:51:48] <font color="#0000fc">azeem:</font> installation of x-shapefile.xml does not seem to honor DESTDIR<BR>
[13:51:50] <font color="#600060">Dominus:</font> on the up side, u7shp now builds for me as well :)<BR>
[13:52:16] <font color="#005000">Marzo:</font> What is the output of "pkg-config --cflags gimpui-2.0 gtk+-2.0" on that system you had that reproduced the issue?<BR>
[13:52:22] <font color="#600060">Dominus:</font> azeem:  data/estudio/*, data/exult_studio.glade but it also needs exult.cfg to find the normal exult.flx files<BR>
[13:52:38] <font color="#600060">Dominus:</font> one moment, starting my vm<BR>
[13:53:15] <font color="#0000fc">azeem:</font> what is u7voice2syx for?<BR>
[13:53:49] <font color="#0000fc">azeem:</font> I guess it should go into the exult package, or is it for game development?<BR>
[13:54:06] <font color="#600060">Dominus:</font> Marzo: https://pastebin.com/UjSsfnBU<BR>
[13:54:26] <font color="#600060">Dominus:</font> azeem, no idea if it has any use these days<BR>
[13:54:26] <font color="#005000">Marzo:</font> @azeem: It should probably not be distributed at all<BR>
[13:54:41] <font color="#0000fc">azeem:</font> ok<BR>
[13:54:59] <font color="#0000fc">azeem:</font> it turned up cause I added some additional build-deps or configure options<BR>
[13:57:31] <font color="#005000">Marzo:</font> Dominus: I found the real issue<BR>
[13:58:32] <font color="#005000">Marzo:</font> For some reason, pkg-config is giving out 'mixed' Windows paths on the systems where having the -I breaks the build, while it is giving msys2 paths on mine<BR>
[13:59:13] <font color="#005000">Marzo:</font> Can you also post the result of "echo $MSYSTEM_PREFIX" on that system?<BR>
[14:00:29] <font color="#600060">Dominus:</font> it's /mingw64<BR>
[14:01:06] <font color="#005000">Marzo:</font> There is why the subst was not working<BR>
[14:01:23] <font color="#005000">Marzo:</font> Now why is pkg-config behaving differently<BR>
[14:02:14] <font color="#600060">Dominus:</font> can you get the msys mingw version somehow?<BR>
[14:06:20] <font color="#005000">Marzo:</font> Can you look for the following files and post their contents: /mingw32/lib/pkgconfig/gtk+-2.0.pc /mingw64/lib/pkgconfig/gtk+-2.0.pc /usr/lib/pkgconfig/gtk+-2.0.pc<BR>
[14:21:12] <font color="#005000">Marzo:</font> Dominus: or better yet, can you post the result of "which pkg-config"?<BR>
[14:42:49] <font color="#600060">Dominus:</font> "/mingw64/bin/pkg-config"<BR>
[14:43:58] <font color="#600060">Dominus:</font> and https://pastebin.com/rUNVaPE3<BR>
[14:45:11] <font color="#600060">Dominus:</font> there is no gtk+-2.0.pc file in the other two locations only in mingw64/lib/pkgconfig<BR>
[14:45:26] <font color="#005000">Marzo:</font> I figured that last one<BR>
[14:45:36] <font color="#005000">Marzo:</font> And for what is worth, here is the real issue: https://github.com/msys2/MINGW-packages/issues/5650<BR>
[14:46:11] <font color="#005000">Marzo:</font> Basically, there can be up to 3 different versions of pkg-config.exe in a msys2 install: a 32-bit one, a 64-bit one, and the msys one<BR>
[14:46:25] <font color="#005000">Marzo:</font> The msys one was in my path and returns Unix-style paths<BR>
[14:46:40] <font color="#005000">Marzo:</font> The other two return Windows paths with backslashes<BR>
[14:46:59] <font color="#005000">Marzo:</font> And the makefile was assuming Unix style<BR>
[14:48:20] <font color="#600060">Dominus:</font> so an older install that had a lot going on over the months might be using the msys one, while a fresh install (as on the ci and mine (sort of)) use the mingw64 one...<BR>
[14:49:03] <font color="#005000">Marzo:</font> And the "fix" actually broke the intent of the original fix, but just happened to work because it had the effect of removing the bad path from includes<BR>
[14:49:16] <font color="#005000">Marzo:</font> So I will revert the change and apply a proper fix<BR>
[14:49:22] <font color="#600060">Dominus:</font> thanks!<BR>
[14:51:11] <font color="#600060">Dominus:</font> marzo: as for having these fixes in the v1.8.x, should I cerry pick (which I know how to do) or merge it somehow (which I don't know, especiallyas I reverted the exult as lib commit)<BR>
[14:51:14] <font color="#600060">Dominus:</font> ?<BR>
[14:51:58] <font color="#005000">Marzo:</font> Cherry-pick would be better<BR>
[15:28:43] <font color="#005000">Marzo:</font> Dominus: fixed<BR>
[17:31:48] <font color="#600060">Dominus:</font> thank you Marzo<BR>
[18:08:43] <font color="#600060">Dominus:</font> for "fun" I tried submitting the iOS version to the Apple AppStore... First review didn't like the name (Exult-iOS because Exult was already taken) AND doesn't like that it shows an error on first launch because of the missing game files :)<BR>
[18:09:04] <font color="#600060">Dominus:</font> This might stop Exult entirely on the App Store...<BR>
[18:15:02] <font color="#0000fc">Philantrop:</font> Dominus: Exult's GPLv2 licence would prevent it from being published on the Appstore, wouldn't it? <BR>
[18:17:08] <font color="#600060">Dominus:</font> no, it doesn't prevent it from being published but anyone that wants to exercise his rights as contributor to Exult can have it pulled<BR>
[18:21:11] <font color="#0000fc">Philantrop:</font> Ah, ok, I thought I dimly remembered some clause in the Appstore's terms and conditions prohibiting GPL-licenced software. <BR>
[18:27:43] <font color="#600060">Dominus:</font> I half expect someone to file a claim and have it pulled eventually - basically *I* am breaking the GPL, not Apple.<BR>