[01:54:57] --- DominusExult is now known as Dominus
[19:14:57] <Dominus> Marzo, found out that the intro withut subtitles is not timed right for the German version...
[19:15:15] * Dominus is forcing his daughter to play Exult
[19:15:48] <Dominus> and found some other bugs in the ios port while playing with her...
[19:20:12] <Marzo> Dominus: technically speaking, the subtitles should not b timed at all; in the original, they only advance when you click or press a key
[19:20:33] <Marzo> (since they don't show when voice is enabled)
[19:21:55] <Marzo> The guardian stays looping the animation all the time
[19:23:05] <Marzo> But if you want, we could change the way subtitles are done to accommodate for this
[19:25:19] <Marzo> For example: the first line of each subtitle group could have three integers at the start: one giving the number of lines in the group, one for the starting time of the subtitle, and one for the ending time of the subtitle
[19:25:25] <Dominus> Marzo, I meant that it is not timed right without subtitles. The Guardian is still ranting on while the screen already changed to the computer screen ;)
[19:26:02] <Marzo> This would allow synching the subtitles, as well as accommodating the regional differences
[19:26:18] <Dominus> If I remember correctly you wrote that one can mod the intro timings?
[19:26:22] <Marzo> Oh, that is not right
[19:26:52] <Dominus> Probably needed for the regional games
[19:27:01] <Marzo> By overriding a file included in a flex file, yes
[19:27:50] <Marzo> Hm, the original may stay waiting until the voice finishes playing
[19:28:29] <Dominus> Seems that is another reason to recognize the localized versions
[19:28:29] <Marzo> Is the audio longer in German?
[19:28:37] <Dominus> I think so
[19:28:57] <Dominus> I will need to watch and time in Dosbox
[19:29:29] <Dominus> I only watched the outro so many times and never paid attention to the german intro
[19:31:19] <Dominus> I'll write a detailed bug report later. Just now noticed that ;)
[19:31:55] <Marzo> I will add code to check if voice is still playing, and keep looping the lips until it is
[19:32:14] <Marzo> (but not right now, will just add to my todo list)
[19:38:10] <Marzo> Added
[19:39:02] <Malignant_Manor> Marzo: wjp : what do you think of ptgeorge's fix? https://github.com/exult/exult/commit/2ac956d9bd226ce09ec647e4c2144f6279da975d
[19:39:59] <Malignant_Manor> He may be waiting for a response before moving onto other bugs. The bug tracker link is https://sourceforge.net/p/exult/bugs/1887/
[19:44:54] <Marzo> The original had a hack for the black sword: its unready event was done by way of a script instead of directly
[19:46:06] <Marzo> This can be seen by opening a gump and removing the black sword from inventory: it only returns when you close the gump
[19:46:51] <Marzo> So the "correct" solution would be to add a special case for the black sword
[19:47:20] <Marzo> His fix is simpler; if it works, I have no problems with it
[19:48:22] <Malignant_Manor> Do you foresee any issues?
[19:59:14] <Marzo> No; but Exult is a complex enough system that it is impossible to be sure
[20:26:35] <Malignant_Manor> The fix seems to work fine. I updated the bug tracker with our conversation.
[20:28:08] <Malignant_Manor> Both Exult and the original engine don't have the black sword teleport back when you put in a held container and place that container on the ground.