[01:50:11] --- DominusExult is now known as Dominus
[11:25:38] <Dominus> and here I thought it's best to declare the ints higher up...
[12:05:46] <Marzo> This was a holdover from the first version of C that people still do to this day
[12:07:36] <Marzo> In C++ you can have nontrivial default constructors, and it can cause performance issues to declare early, then assign a new value
[12:07:50] <Marzo> And in any case, it is better to declare where you will be able to assign a value anyway
[12:19:07] <Dominus> thanks for the clarification!
[15:04:36] <travis-ci> exult/exult#361 (master - 1e5dda7 : Marzo Sette Torres Junior): The build was broken.
[15:04:36] <travis-ci> Change view : https://github.com/exult/exult/compare/eb6b99b24c3f...1e5dda7043b6
[15:04:36] <travis-ci> Build details : https://travis-ci.org/exult/exult/builds/698224484
[16:04:12] <Dominus> marzo: build failure
[16:04:13] <Dominus> ucinternal.cc:1753:13: error: calling a private constructor of class
[16:04:13] <Dominus> 'Usecode_internal'
[16:04:13] <Dominus> return new Usecode_internal();
[16:04:22] <Dominus> ./ucinternal.h:477:2: note: implicitly declared private here
[16:04:30] <Marzo> I know, I already fixed it locally, just need to push
[16:07:14] <Dominus> alright :)
[16:14:02] <Dominus> huh, when did we get the .clang-tidy file? and are we now clang only? or do these things you did today work on other compilers? (not complaining, just wondering :))
[16:16:02] <Marzo> Clang tidy is a tool included with clang/llvm
[16:16:09] <Marzo> It can be used independently from clang
[16:16:35] <Marzo> My IDE, for example, is configured to run clang-tidy on open files when they are saved
[16:42:44] <Dominus> compiled fine now on macOs and iOS :)
[16:47:40] <Marzo> The issue was #ifdef hell
[16:49:23] <Dominus> some conversion loses precision issues the xcode compiler picks up for iOS https://pastebin.com/pk9tnSTN
[16:49:42] <Dominus> not new though. don't know if I reported them before
[16:50:38] <Dominus> in.tellg() and out.tellg() stuff
[16:50:55] <travis-ci> exult/exult#362 (master - 72cbedc : Marzo Sette Torres Junior): The build was fixed.
[16:50:55] <travis-ci> Change view : https://github.com/exult/exult/compare/1e5dda7043b6...72cbedc28d6e
[16:50:55] <travis-ci> Build details : https://travis-ci.org/exult/exult/builds/698249561
[17:08:42] <Marzo> For our use cases, these will not be relevant; the file sizes we deal with don't come even close to 4GB
[17:09:23] <Dominus> right
[17:12:18] <Marzo> Might be worth fixing them at some point, though, just in case
[17:13:08] <Marzo> I do remember a case where someone had written a monstruous copy/paste usecode function that compiled to more than 4GB, the maximum we can handle in Exult/UCC
[17:13:38] <Dominus> he he
[23:47:45] --- DominusExult is now known as Dominus