[15:13:50] --- zymlpeebumzgcpxz is now known as gcmlhlxaacmfudmq
[15:13:54] --- gcmlhlxaacmfudmq is now known as Marzo
[16:45:43] <Dominus> Marzo, I made a little patch for the spellbook page turning, so each page gets turned to get back to the bookmarked page. (currently we only turn one page regardless of how many pages are between the bookmark and the current page)
[16:45:48] <Dominus> http://pastebin.com/dQDrWPyD
[16:46:10] <Dominus> but I guess this could be made shorter
[16:46:21] <Dominus> instead of two while statements
[16:46:32] <Dominus> This makes it more like the original.
[16:47:08] <Dominus> The original also always opens the spellbook to page 1 and then auto turns the pages to get to the bookmark
[16:47:20] <Dominus> I don't like that :)
[16:47:48] <Marzo> Something maybe like this:
[16:47:49] <Marzo> int delta = sign(bmpage - sgump->page); while (bmpage != sgump->page) sgump->change_page(delta);
[16:51:39] <Dominus> doesn't know what sign is
[16:51:58] <Dominus> use of undeclared identifier 'sign'
[17:23:50] <Marzo> Oh, I forgot, there is no such function in C or C++, I always add it to my projects
[17:24:40] <Marzo> Add this somewhere:
[17:24:54] <Marzo> template <typename T> int sign(T val) {return (T(0) < val) - (val < T(0));}
[17:25:03] <Marzo> (and feel free to reformat it)
[17:45:18] <Dominus> Thanks! With this I can probably manage it.
[17:50:06] <Dominus> Another thing Marzo, do you mind if I move the general load timbre etc messages to #ifdef DEBUG? While leaving those that might indicate an error
[17:50:35] <Marzo> Inside mt32emu?
[17:50:46] <Marzo> Might be better to just define the constants it needs
[17:52:19] <Dominus> These are in Lowlevelmidi driver
[17:52:33] <Marzo> Ah
[17:52:37] <Marzo> Feel free then
[17:52:54] <Dominus> K
[20:15:46] <GitHub> [exult] DominusExult pushed 2 new commits to master: https://git.io/vXDeJ
[20:15:46] <GitHub> exult/master 0e3eb0c DominusExult: Making LowLevelMidiDriver is less verbose now in non-Debug builds
[20:15:46] <GitHub> exult/master 3aa511e DominusExult: When you now click the Spellbook bookmark all pages between the current and the bookmarked page will turn....
[20:18:35] <GitHub> [exult] marzojr pushed 1 new commit to master: https://git.io/vXDe0
[20:18:35] <GitHub> exult/master 271d7a6 Marzo Sette Torres Junior: Getting rid of -Wunused-const-variable, since it generates thousands...
[20:57:38] <GitHub> [exult] marzojr pushed 1 new commit to master: https://git.io/vXDL2
[20:57:38] <GitHub> exult/master a8e7f72 Marzo Sette Torres Junior: Fixing misleading identation in shortcutbar [-Wmisleading-indentation].