[10:39:38] --- Dominus1 is now known as Dominus
[18:07:52] <Dominus> wjp, do you have time to review my single/double rightclick pathfind patch? http://pastebin.com/Q4L9pBGG
[18:08:26] <Dominus> I also need an opionion whether to leave the old double-right_move setting orphaned in the cfg or remove it
[18:14:08] <wjp> why the > 500 check?
[18:14:34] <Dominus> that it is not a doubleclick
[18:14:43] <wjp> also, it would be better to make this option an enum instead of an int
[18:15:09] <wjp> but now it would go to the first spot if you rapidly click on two different spots
[18:15:36] <wjp> but I suppose you tested how it behaves in practice and I didn't, so don't pay too much attention to this :-)
[18:16:16] <Dominus> hmm, so you think it would be better to accept that it will also react to a double click? hmm, and you are right about the rapid clicking on two d
[18:16:27] <Dominus> actually it won'T go to any spot if you rapid click
[18:18:26] <Dominus> and yes, if an enum meant I could use "no, single, double" as options that would probably be better but I need to find an example of this first so I can copy it :)
[18:31:43] <Dominus> hmm, I think I can go by the example of sample_rates in audiooptions_gump.cc
[18:33:12] <Dominus> what do you think of whether to orphan the old setting "allow_double_right_move" or remove it and use the setting it was set to?
[18:33:55] <wjp> I haven't looked at our config class' capabilities in ages, but if it's easy to migrate, I'd do that
[18:34:14] <Dominus> I have some pseudo code in https://sourceforge.net/tracker/index.php?func=detail&aid=3572527&group_id=2335&atid=302335
[18:34:18] <Dominus> for this
[18:35:12] <Dominus> also copied from some other setting we migrated like this
[22:58:19] --- Dominus is now known as Guest87928
[22:58:19] --- Dominus1 is now known as Dominus