[00:00:57] --- Dominus1 is now known as Dominus
[09:15:31] --- Dominus1 is now known as Dominus
[09:51:07] <Dominus> wjp, I need help again with porting the code sign stuff from nuvie to exult. Everything works except the last test to echo the ID
[09:51:09] <Dominus> http://pastebin.com/14exBtNz
[09:51:34] <Dominus> I'm doing it wrong and tried many things but always get "test: too many arguments"
[10:07:24] <wjp> it needs quotes around $with_macosx_code_signature in the test line
[10:07:42] <wjp> hm, also in nuvie, come to think of it
[10:10:01] <Dominus> thanks, that worked
[14:49:40] <Dominus> wjp, only now had time to do more and I'm still doing it wrong. The test is not conclusive so even if I pass no sig, the echo is shown
[14:50:09] <Dominus> and it's not getting written to config.h if I pass a sig...
[14:50:17] <Dominus> but I have to go again... :(
[14:54:54] <wjp> oh, that's actually a pretty good point... there's no check to see if the option is passed at all :-)
[14:58:57] <wjp> this is probably how I'd do the nuvie one: http://www.usecode.org/misc/nuvie_codesign.txt
[14:59:52] <Dominus> ah, so the if !=x; test was useful after all :)
[15:00:33] * Dominus could steal away from bathing the little one...
[15:15:57] <Dominus> it seems I have no idea how to properly test for the final echo correctly
[15:24:42] <wjp> the same != x one, probably
[15:27:18] <Dominus> then I still get the empty "Mac OS X code sign ID...... :"
[15:27:32] <Dominus> when I don't pass a sn ID
[15:31:43] <wjp> can you show the current version you have?
[16:09:53] <Dominus> wjp http://pastebin.com/mmD0ZSG7
[16:10:37] <Dominus> I tried if test x$with_macosx_code_signature = x; also with != xnone
[16:11:26] <Dominus> and sorry, I always have to look after the little one, that's why my responses are a bit late at times
[16:12:46] <wjp> it should just be != x;, I think
[16:13:24] <wjp> (and don't forget the quotes around $with_macosx_code_signature)
[16:14:20] <wjp> the reason is that with_macosx_code_signature is set to "" by the AC_ARG_WITH macro if that option isn't passed
[17:09:40] <Dominus> dang, I messed with the quotes because it wasn't working as I thought it should. with the quotes and =x; it works (since we want to show the echo when there is something in $with_macosx_code_signature)
[17:11:27] <Dominus> ok, now it's gonna go into trunk
[17:24:21] <Dominus> now onto Pentagram
[17:39:03] <wjp> that echo test line is still broken
[17:39:15] <wjp> the $ is outside the quotes and the = should really be !=
[17:39:26] <wjp> it should be identical to the one testing if the option is passed earlier
[17:39:51] <wjp> (cooking, so I'm a bit brief)
[17:40:22] <Dominus> yes, I noticed in Pentagram that it should be !=
[17:40:38] <Dominus> that I put $ outside was a mistake...
[18:06:10] <Dominus> encountering other difficulties with pentagram, gonna bug you later. first gonna try to sort it out myself ... :)
[18:09:55] <wjp> because there's no automake, you might have to add a line to the top of Makefile.in along the lines of OSX_CODE_SIGNATURE = @OSX_CODE_SIGNATURE@
[18:10:09] <Dominus> yeah, just figured that out :)