[10:00:00] <Dominus> wjp what do you think of the fix for the scale2x problem, malignant posted here the other night
[10:01:04] <wjp> that's not a fix
[10:01:53] <Dominus> ok
[10:03:39] <Dominus> so, do you think we can release? :)
[10:03:58] <wjp> it disables the guard bands, but I don't know exactly what the guard bands do. They may be for reducing scaling artifacts around the edges
[10:04:26] <wjp> maybe disable scale2x entirely?
[10:04:45] <Dominus> ok, disabling without knowing what it does, is not the best.
[10:04:55] <Dominus> I don't care about Scale2x :)
[10:12:02] <Dominus> we get slowly more spam on the forum these days...
[11:19:53] <wjp> yes.. I've deleted a few too, recently
[16:14:17] --- dominus is now known as Dominus|away
[20:44:47] <wjp> Dominus|away : I think I understand the scale2x issue a bit now
[20:48:01] <wjp> it's actually causing artifacts in the other scalers too, but scale2x is far more noticable
[20:57:50] <Malignant_Manor> I don't know the specific purpose of the guard bands either. I just wanted to list that the problems seem to be the result of them so someone who has a better idea of what they were doing could make a proper fix.
[20:59:15] <wjp> I think Super2xSaI has a vertical off-by-one
[20:59:25] <wjp> Malignant_Manor: yup, I understood; thanks
[21:00:20] <Malignant_Manor> Scale2x seemed to be off by whatever band guard offset was on the y axis.
[21:00:43] <wjp> it thought it hit the end of the screen 4 pixels early
[21:01:01] <wjp> so it wasn't updating its internal state anymore there
[21:01:10] <wjp> I fixed it locally
[21:01:33] <Malignant_Manor> I think I set the band guard hiigher and then I got more lines on the bottom.
[21:01:45] <wjp> yes, the 4 is guard_band
[21:01:48] <Malignant_Manor> I didn't really do much testing.
[21:01:48] <wjp> but it's fixed :-)
[21:02:23] <Malignant_Manor> So, you just found a solution that isn't committed?
[21:03:11] <wjp> haven't committed it yet, no
[21:03:29] <wjp> just looking if those Super2xSaI/SuperEagle offsets are related
[21:03:42] <wjp> they seem to shift the image by a pixel
[21:09:34] <wjp> I'll ignore those for now
[21:10:58] <wjp> Dominus|away: committed
[21:13:43] <wjp> the scummvm versions of Super2xSaI/SuperEagle have the same shifts
[21:27:10] <Malignant_Manor> Would fill quality affecting game resolution be a bug with a fixed resolution?
[21:28:32] <Malignant_Manor> fill quality =fill_scaler
[21:29:52] <wjp> explain?
[21:33:33] <Malignant_Manor> When changing from point to bi linear fill quality in fill mode fill, the game resolution seemed to change.
[21:34:13] <Malignant_Manor> Couldn't reproduce it when I restarted and tried to give a more exact explanation.
[21:34:56] <wjp> that shouldn't affect it no
[21:37:44] <Malignant_Manor> Do you feel like tackling an ai bug?
[21:38:20] <Malignant_Manor> https://sourceforge.net/tracker/?func=detail&aid=2961387&group_id=2335&atid=102335
[21:41:35] <wjp> hm, not right now
[21:42:46] <wjp> maybe after release
[22:28:45] <wjp> time to go; good night