[13:35:03] <Colourless> hi
[13:35:25] <wjp> hi
[13:35:35] <wjp> I was just looking at the exult bug tracker...
[13:35:41] <wjp> we have a huge amount of bugs in there...
[13:36:08] <wjp> some rather serious
[13:37:55] <wjp> could disappearing npcs be related to the map cache-out functions?
[13:46:31] <wjp> (particularly the SS NPCs, as they're not "real" NPCs)
[13:47:20] <Colourless> hmm. could be
[14:12:56] <wjp> if I understand this correctly, the SS NPCs would be classified as a monster and deleted
[14:13:08] <wjp> (Map_chunk::get_obj_actors)
[14:15:05] <Colourless> monsters should only be deleted (as all items) if the temporary flag is set
[14:16:29] * wjp nods
[14:17:42] <Colourless> so, do you think my advice of waiting a few days after the want map cache out change was a good idea :-)
[14:18:44] <wjp> yes :-)
[14:19:22] <wjp> I also feel like my idea that this was too big a change for a beta cycle was right :-)
[14:19:57] <Colourless> i still disagree.
[17:40:21] <wjp> anyway, let's see about fixing this
[17:41:04] <wjp> would changing that "if (actor == 0 || each->is_monster())" be sufficient?
[17:41:28] <wjp> I'm not really all that familiar with this code
[17:41:29] <Colourless> yes i'm guessint so
[17:41:50] <wjp> items get saved in that case, but it looks like actors have an ireg_size of 0
[17:42:25] * wjp looks around for the temporary flag
[17:42:56] <Colourless> try this:
[17:42:56] <Colourless> if (actor == 0 || (each->is_monster() && each->get_flag(Obj_flags::is_temporary))) {
[17:43:22] <wjp> thanks :-)
[17:43:45] <wjp> we should make sure this kind of code is properly documented in pentagram
[17:43:53] <wjp> preferably in some central location
[17:44:50] <wjp> ok, SS NPCs stay around now
[17:45:23] <Colourless> :-)
[17:45:29] <wjp> I guess I'll just commit this then :-)
[17:48:56] <wjp> "confiscated items disappear in Moonshade" sounds like it should be fixed now too
[17:55:21] <wjp> "SI: Luther and Caladin" missing... hmmm...
[17:55:27] <wjp> both are around (4095,4095)
[17:56:37] <wjp> Caladin has health -9, Luther health 28
[17:57:01] <Colourless> well Caladin obviously died :-)
[17:57:19] <wjp> so it would seem :-)
[17:58:41] <wjp> I wonder how and why he died, though