[14:15:07] exult-bridge:Dominus: @Marzo the issue https://github.com/exult/exult/issues/242 seems to be caused by your commit https://github.com/exult/exult/commit/403251447f3af0424f021309dd740637043c8764 i30817 thought it was caused by changing midi settings but it's triggered by entering the setup menu, exiting it and reentering it from the main Exult menu.
[14:30:18] exult-bridge:Marzo: Hm. I can't get a crash from it; when I try it, it just shows a blank screen when returning to setup
[14:31:28] exult-bridge:Marzo: The fix seems to be dead simple, though
[14:31:39] exult-bridge:Marzo: Can you reproduce the crash locally?
[14:33:04] exult-bridge:Dominus: yes, I was able to pinpoint it with my macOS snapshots
[14:34:13] exult-bridge:Marzo: Add these lines to shapeid.cc in Shape_manager::load_gumps_minimal and let me know if the crash is fixed: U7FileManager::get_ptr()->reset(); // Cache no longer valid. shape_cache[SF_GUMPS_VGA].clear(); shape_cache[SF_EXULT_FLX].clear();
[14:35:13] exult-bridge:Dominus: one moment
[14:39:01] exult-bridge:Dominus: @Marzo that works (added them above "return true;")
[14:42:33] exult-bridge:Dominus: thanks!
[14:44:42] exult-bridge:Marzo: I added code to clear all caches to Shape_manager::load too just in case, but it did not seem to make a difference
[14:45:14] exult-bridge:Marzo: Looking at that function made me remember I have to fix how outlines work in Exult to be like the original
[14:46:58] Dominus: outlines? poison, protected, hurt - those?
[14:47:02] exult-bridge:Marzo: Yes
[14:48:03] exult-bridge:Marzo: The original mapped several (close-to) black palette entries values to a color, instead of it being just the outline
[14:48:53] exult-bridge:Marzo: Kind of similar to the remapping I coded in for the BG title screen so that it can be used with the main game palette for paperdolls
[14:49:53] exult-bridge:Dominus: Hmm, I have to look at that closely it seems (most easiest the poison outline)
[14:51:18] exult-bridge:Marzo: The major issue is that I have to find a way to combine that with translucency, and this will be a bit of work
[14:51:58] exult-bridge:Marzo: I think I will have to refactor the shape rendering code because it is exceedingly redudant
[14:52:16] exult-bridge:Marzo: There are several copies of the drawing code with minor differences for each special case
[14:52:17] exult-bridge:Dominus: refactor.... makes me want to hide...
[14:52:23] exult-bridge:Marzo: And we can do better in c++