[02:48:59] --- DominusExult is now known as Dominus
[09:25:01] <Dominus> Good morning Marzo! Last night I worked on the music sync and submitted both a_ and r_ xmi files as well as a mt32 (munt) recording of it as ogg. I don't think I ever want to see the intro again...
[09:25:27] <Marzo> :)
[11:54:32] <Dominus> as I couldn't find an editor for xmi I've edited them by looking for patterns https://www.dropbox.com/s/bwg3m4mhgp6h8qs/r_sintro_xmi_pattern.png?dl=0
[11:56:16] <Dominus> and then added this by doubling the big three part section and added another part of it without the up/down chime in the beginning https://www.dropbox.com/s/jmi918nrgmcvba7/r_sintro_xmi_final.png?dl=0
[11:57:04] <Dominus> I'll probably write something on how the extended intro was added and what needed to be done outside of the code
[12:16:23] <Dominus> Marzo, while I'm at it, I can also see about furthering the BG intro sfx plan. I still have the sfx files here and the flx files are 2.1 and 2.4 MB big. so an additional 4.5MB. Question is should I add additional flx files (exult_bg_sfx_sb.flx/exult_bg_sfx_mt.flx) or add them to the main exult_bg.flx?
[12:16:40] <Dominus> I can again dabble at it in my fork
[12:59:07] <Marzo> Either one works; I think maybe putting them on exult_bg.flx is a bit better, though
[14:16:14] <Dominus> he he, the lgtm analysis is fun to read. in wuc.cc our variables *fo *fi :)
[15:14:50] <Marzo> SI extended intro is live
[15:17:41] <Dominus> ooohhh, THANKS!
[15:17:50] * Dominus is off looking at the code changes
[15:22:58] <Dominus> I need to test, midi_driver->is_mt32()), I think midi also uses the R intro, but I'm not sure
[15:24:11] <Marzo> It is remapped under the hood to the correct one
[15:24:19] <Dominus> ugh... hard sigh on my accidental //**************** commit
[15:26:36] <Dominus> soooo... how do you like it?
[15:27:08] <Marzo> The music edit was very well done, and the intro is nice
[15:27:25] <Marzo> Overall, a good job
[15:28:45] <Dominus> thanks. I really did enjoy watching it the first dozen times :)
[17:11:43] <Dominus> hmm, Marzo, does playing the sfx in the intro need similar code you just added for the midi drivers? Or does this work somewhat with play_wave_sfx and Flex *get_sfx_file() ? And if that works... could you give me a sample code?
[17:12:14] <Dominus> (and curiolsy our Audio::get_ptr()->play_sound_effect(115, AUDIO_MAX_VOLUME, 0, 0); in bggame.cc is not working (out of range))
[18:25:24] <travis-ci> exult/exult#491 (master - 4e28ea1 : Dragon-Baroque): The build has errored.
[18:25:24] <travis-ci> Change view : https://github.com/exult/exult/compare/093d1a2a18b5...4e28ea10800c
[18:25:24] <travis-ci> Build details : https://travis-ci.com/exult/exult/builds/216341325
[19:01:31] <Marzo> Dominus: one thing I thought of when looking at our downloads page: maybe we should think about bundling Neutron Dragno´s GM patches into exult_(bg|si).flx and use them instead of the normal songs whenever GM conversion is selected?
[19:02:26] <Marzo> And regaring the sfx, the code changes would be very different; I will probably have to write a specific function for it
[19:37:32] <Dominus> ugh
[19:41:42] <Dominus> Marzo, did you notice my pull requests on Dragon Baroque's no x11 branch? They are not rebased on current code and won'T get to do that today and I can just redo it in the exult git. 1 is adding better handling of macOS in configure.ac and in exult.cc (brcause SDL_DROP... only works without x11 in current SDL mercrurial) the other two are a bit cleanup of the xdnd stuff I noticed
[19:42:18] <Marzo> I didn see it, no
[19:42:25] <Dominus> https://github.com/DominusExult/exult/tree/exult_x11_dependencies
[19:46:01] <Marzo> The cleanup commit I have already done (https://github.com/DominusExult/exult/commit/d657e4b4b09684fbc250b77cf3922ebac9442e2b)
[19:47:00] <Marzo> The other one I missed (https://github.com/DominusExult/exult/commit/058945e104734e9045b343c807b9609312f3411b)
[19:50:02] <Marzo> Out of curiosity, what is the bug in question?
[19:53:44] <Marzo> It is basically adding 3 commits on top of his?
[19:55:36] <Marzo> Seems like a simple case of cherry-picking the commits, they should apply cleanly
[19:56:36] <Dominus> yes, but if you did the cleanup one already, it's jsut the two commits (configure.ac and the syswmevent)
[19:58:02] <Dominus> SDL2's DROPFILE needed a way to tell where the cursor was over the window when a file drops. This works in their x11 implementation but not in the cocoa one. So Dragon Baroque wrote that patch, too, and it got instantly added
[19:59:10] <Dominus> https://bugzilla.libsdl.org/show_bug.cgi?id=5449
[20:09:38] <Marzo> Hm
[20:13:39] <Marzo> Dominus: merged in
[20:15:31] <Dominus> maybe they (SDL2) would be open to expand SDL_DROPFILE to accept more data so we can readd the green placement grid. but that would be a much bigger change to SDL2 across all backends
[20:15:36] <Dominus> thank you
[20:16:09] <Marzo> Amy thoughts on the GM patch idea?
[20:21:28] <Dominus> It's a good idea
[20:21:52] <Marzo> We probably should contact Neutron Dragon about it
[20:22:07] <Marzo> He will probably be fine with it, but it is better to ask first
[20:23:21] <Marzo> Oh, and I added a link to exult.info on out Github page
[20:47:13] <Dominus> oh, good. I'm gonna catch up now on your commits :)
[21:06:19] <Dominus> this no more need for x11 is a game changer for me on macOS :)
[21:07:03] <Dominus> first I can finally provide a build of Exult Studio on our download page *and* I can just leave studio support in the standalone Exult.