[08:52:15] <Dominus> wow, with clang Exult compiles in a snap
[08:54:24] <Dominus> just this warning on utils.h creeps up a lot
[08:54:25] <Dominus> http://pastebin.com/5cudDwZJ
[09:03:00] <Dominus> and some other warnings will report later
[09:07:37] <Shozan> yes that comparison would not be safe
[10:02:33] <Colourless> technically they are problems. in reality not necessarily a problem on any compiler thats playing safe
[10:03:41] <Colourless> i should probably be a ptrdiff_t instead of size_t
[11:02:47] <Dominus> I'll try that later. thanks c
[12:33:54] <Dominus> all the warnings http://pastebin.com/MYcgHuc7
[12:34:37] <Dominus> colourless also some fmopl warnings (line 125 of the pastebin)
[12:38:26] <Shozan> are you cleaning the code?
[12:38:58] <Dominus> no, but I tried compiling on clang just now and it produces nice readable, standoutish warnings :)
[12:39:18] <Shozan> indeed
[12:39:57] <Dominus> and with those I can try to bug my teammates :)
[12:40:06] <Shozan> :)
[12:40:28] <Shozan> what is it normally compiled with?
[12:40:40] <Dominus> gcc
[12:40:46] <Shozan> just asking, becuase the warnings you posted should be picked up by pretty much anything
[12:40:52] <Dominus> plain gcc 4.2 on my system
[12:40:58] <Shozan> *any compiler
[12:41:06] <Dominus> probably are but I never saw them stand out :)
[12:41:11] <Shozan> ah
[12:43:03] <Dominus> and as I'm not good at programming I wonder if those warnings could be real problems or can be ignored
[12:46:54] <Dominus> wjp, may I bug you about this? Can you take a look at those warnings whether I can safely remain ignorant of those?
[12:47:08] <Dominus> http://pastebin.com/MYcgHuc7
[12:48:31] <Shozan> many looks like style issues. like the ternary operator things (?:) are mostly warnings because it's not extremely clear from quickly watching the code what it is evaulating in all steps
[12:49:03] <Shozan> a couple of parentheses would clear that up
[12:49:57] <Dominus> the utils.h warning is indeed gone when using ptrdiff_t instead of size_t
[12:50:17] <Shozan> yes, because size_t is unsigned
[12:50:27] <Shozan> and the code was checking if it was below 0 :)
[12:51:39] <Shozan> well.. not below zero, but checking if it was more than 0 rather
[12:51:45] <Shozan> and it is always true
[12:54:42] <Dominus> thanks for trying to explain this to me - I'm bad with this
[12:57:55] <Shozan> np :)
[13:00:43] <Shozan> i didn't realise people were still maintaining exult
[13:01:12] <Dominus> har har har :)
[13:01:16] <Dominus> make
[13:01:22] <Dominus> wrong window
[13:02:33] <wjp> shapeinf.cc:551 is a real error
[13:03:59] <wjp> and the FMOplMidiDrivers ?: ones too
[13:04:36] <wjp> and the effects.cc ?: one too
[13:10:00] <Dominus> thanks for taking a look