[01:18:36] --- sh[4]rm4 is now known as sh4rm4
[02:10:49] --- ParuNexus is now known as TheGunrHar
[02:30:13] --- TheGunrHar is now known as ParuNexus
[15:23:09] --- sh[4]rm4 is now known as sh4rm4
[17:57:47] <Dominus> Marzo, there is a curios money exchange bug http://exult.sourceforge.net/forum/read.php?f=1&i=740893&t=740893
[17:58:20] <Dominus> it seems when the party members are already mostly at their carrying capacity the exhanged money gets lost
[17:58:24] <Dominus> in BG
[17:58:41] <Dominus> in SI there is a check for this, I think
[17:58:54] <Marzo> In BG, I think that the usecode just ignores what can't be given in this case
[17:59:05] <Marzo> In SI, the usecode drops the remainder on the floor
[18:00:00] <Dominus> hmm, we do exchange all (all god bars and nuggets are gone) but the over capacity gold is lost
[18:01:47] <Marzo> Hm. The usecode in BG tries to give all the gold coins first, and removes the bars and nuggets only if you can carry it all
[18:05:50] <Marzo> No, looking at the intrinsics documentation, our behavior matches that of the original
[18:06:25] <Dominus> so we do something wrong
[18:06:35] <Marzo> UI_add_party_items returns an array of party members that received gold
[18:06:53] <Marzo> If none received anything, the condition check fails
[18:06:58] <Marzo> Otherwise, it succeeds
[18:07:27] <Marzo> SI has additional behavior in the intrinsic that handles the case where not everything was given
[18:07:41] <Dominus> i can do some regression checking later
[18:08:11] <Dominus> i remember this broken in the past and then being fixed
[18:08:14] <Marzo> We can compare it with the original; I don't trust anyone's memory
[18:08:30] <Dominus> wayyyyyy back
[18:10:03] <Dominus> maybe we introduced some tiny little thing that breaks this...
[18:24:50] <Dominus> Marzo: what's interesting is that our "hackmover enabled" override is not working for this usecode controlled thing
[18:25:31] <Dominus> with hackmover you can normally carry everything and everything fits into containers
[18:25:59] <Dominus> but the gold exchange fails all the same ;(
[18:26:05] <Marzo> I guess we don't check for it in the intrinsic
[21:01:57] --- RadoS is now known as radO
[22:40:13] <Dominus> Marzo, just checked the original, with hackmover enabled you receive all the gold in case of not enough capacity
[22:40:58] <Dominus> but hackmover disabled it will act exactly like with Exult
[23:19:39] <Marzo> Dominus: See, I told you :-)