[00:18:43] --> Rottingbeef-2 has joined #exult
[00:28:22] <-- Rottingbeef-2 has left IRC (Ping timeout: 272 seconds)
[00:49:50] <-- BrainChild has left IRC (Remote host closed the connection)
[00:50:42] --> BrainChild has joined #exult
[00:56:13] <-- BrainChild has left IRC (Ping timeout: 256 seconds)
[00:57:44] --> Rottingbeef-2 has joined #exult
[01:01:56] <-- Rottingbeef-2 has left IRC (Ping timeout: 246 seconds)
[01:27:44] --> BrainChild has joined #exult
[01:34:10] --> DominusExult has joined #exult
[01:34:10] <-- DominusExult has left IRC (Changing host)
[01:34:10] --> DominusExult has joined #exult
[01:34:10] --- ChanServ gives channel operator status to DominusExult
[01:35:32] <-- Dominus has left IRC (Ping timeout: 246 seconds)
[01:35:32] --- DominusExult is now known as Dominus
[01:37:59] <-- BrainChild has left IRC (Ping timeout: 246 seconds)
[01:43:38] --> Rottingbeef-2 has joined #exult
[02:54:40] <-- Rottingbeef-2 has left IRC (Ping timeout: 272 seconds)
[03:35:28] --> BrainChild has joined #exult
[03:51:10] <-- BrainChild has left IRC (Ping timeout: 256 seconds)
[05:48:17] --> BrainChild has joined #exult
[06:02:46] <-- BrainChild has left IRC (Ping timeout: 272 seconds)
[07:06:31] <-- Lightkey has left IRC (Ping timeout: 240 seconds)
[07:19:50] --> Lightkey has joined #exult
[07:59:55] --> BrainChild has joined #exult
[08:15:14] <-- BrainChild has left IRC (Ping timeout: 256 seconds)
[08:23:22] --> Marzo has joined #exult
[09:25:04] --> BrainChild has joined #exult
[11:26:14] <Marzo> Hm. Image_buffer16 from ibuf16.{cc,h} seem to be completely unused in Exult or ES
[11:32:31] <-- BrainChild has left IRC (Remote host closed the connection)
[11:33:42] --> BrainChild has joined #exult
[11:34:26] * Marzo tests removing it entirely
[11:39:10] <-- BrainChild has left IRC (Ping timeout: 256 seconds)
[11:39:54] <Marzo> Compiles, links, works
[11:39:57] * Marzo commits
[11:40:17] <Dominus> famous last words :)
[11:41:42] <Marzo> But seriously, there was a single reference to the Image_buffer16 class outside of ibuf16.{cc,h} -- a 'friend class Image_buffer16;' line in imagebuf.h
[11:42:11] <Marzo> Basically, this meant that Image_buffer16 could access everything from imagewin... but could not be created
[11:43:18] <Marzo> Good news is that most of the -Wcast-align warnings you posted are now gone
[11:43:41] <Dominus> the ones from the Raspberry compile?
[11:44:13] <Marzo> Yes
[11:44:24] <Marzo> Most of them were from those files
[11:44:33] <Dominus> ah yes...
[11:44:55] <Marzo> I am seeing now that GCC has a -Wcast-align=strict version that warns on all architectures
[11:45:01] <Marzo> I will enable it and take a peek
[12:02:21] <Marzo> Huh
[12:02:29] <Marzo> The Pi compile missed quite a few cases
[12:05:49] <Dominus> maybe I made a mistake in shortening the list. it all seemed to stem from the same includes, so I shortened it. Probably was a mistake
[12:09:38] --> BrainChild has joined #exult
[12:19:08] <-- BrainChild has left IRC (Ping timeout: 260 seconds)
[12:22:36] <Dominus> Marzo: I'm having a logic problem in the InnoSetup installer (win32/exult_installer.iss). Up to now after you entered the paths the installer only checked whether both game paths were invalid. if one was ok, it accepted it without complaining and wrote the incorrect path to the exult.cfg.
[12:22:45] <Dominus> With https://pastebin.com/LGbjY1dq I tried to correct this
[12:23:11] <Dominus> but I'm having a logic problem
[12:24:05] <Dominus> so if SI not valid but BG is and I clicked no on the dialog "...do you wish to continue?" I remain on this setup page. That is what it should be
[12:25:05] <Dominus> but the if (iBGVerified = 0) AND (iSIVerified = 1) then begin will always take me to the next setup page, regardless whether I clicked yes or no (Result True or False)
[12:25:23] <Dominus> so there I do something wrong but I can't spot it
[12:26:24] <Dominus> (I'm in the process of making the installers compatible with newest InnoSetup (6.0.4), right now they are only compatible with 5.0.6
[12:26:42] <Marzo> There seems to be way too many instances of "Result := True;"
[12:32:53] <Marzo> Dominus: try this version: https://pastebin.com/0DcJFj3K
[12:35:29] <Dominus> puh, yes, that works
[12:36:54] <Dominus> thanks
[13:02:32] <Dominus> Marzo, any reason you got rid of the static LDFLAGS in makefile.mingw? With those ( -static-libgcc -static-libstdc++) Exult gets 17MB big, but after strip it's only up to ~ 1 MB bigger and it saves you some of the mingw/gcc dlls
[13:03:19] --> Rottingbeef-2 has joined #exult
[13:03:28] <Marzo> It is generally bad to static link libgcc and libstdc++
[13:05:51] <Dominus> AND, I could make scripted Windows builds (through some patching of makefile.mingw and makefile.common), but probably AppVeyor is better (my build needs libpwinthread.dll or so). If that could be automated to send the varios dist targets in a zip, I could have it automated to build the installers.
[13:06:28] <Dominus> the InnoSetup has a command line tool that I verified I can run scripted via wine
[13:39:24] <-- tsoliman has left IRC (Quit: I've been banished!)
[13:41:48] --> tsoliman has joined #exult
[14:08:19] --> travis-ci has joined #exult
[14:08:19] <travis-ci> exult/exult#337 (coverity_scan - f70a55f : Marzo Sette Torres Junior): The build has errored.
[14:08:19] <travis-ci> Change view : https://github.com/exult/exult/compare/35726eb91d37...f70a55f0c74b
[14:08:19] <travis-ci> Build details : https://travis-ci.org/exult/exult/builds/685325753
[14:08:19] <-- travis-ci has left #exult
[14:16:48] --> BrainChild has joined #exult
[14:31:59] <-- BrainChild has left IRC (Ping timeout: 240 seconds)
[15:49:00] <Dominus> Marzo, you killed the exultmenu :)
[15:49:08] <Dominus> when you click on setup it stalls
[15:50:50] <Marzo> Oh?
[15:51:42] <Dominus> but only in the Setup routine, it fades to black and never returns. Music plays on, though
[15:51:49] <Marzo> Hm. segfault for me
[15:52:43] <Marzo> And I will have to do a debug build because of course I have one without symbols
[15:59:54] <Dominus> that's my bt https://pastebin.com/h8DXJsN1
[16:12:53] <Marzo> Fixed
[16:13:28] <Marzo> My backtrace was actually different, but the underlying issue was the same
[16:24:27] <Dominus> thanks
[16:30:50] --> BrainChild has joined #exult
[16:45:08] <-- BrainChild has left IRC (Ping timeout: 260 seconds)
[18:43:06] --> BrainChild has joined #exult
[18:57:58] <-- BrainChild has left IRC (Ping timeout: 272 seconds)
[19:05:00] <-- Rottingbeef-2 has left IRC (Ping timeout: 260 seconds)
[19:26:52] --> BrainChild has joined #exult
[19:38:35] <-- BrainChild has left IRC (Ping timeout: 264 seconds)
[20:02:16] --> BrainChild has joined #exult
[20:15:29] --> Rottingbeef-2 has joined #exult
[20:39:20] <-- Marzo has left IRC (Ping timeout: 246 seconds)
[21:11:56] <-- BrainChild has left IRC ()