[01:45:29] travis-ci: exult/exult#556 (snapshot-v1.7.0.20210224 - 91099ac : Marzo Sette Torres Junior): The build passed.
[01:45:29] travis-ci: Change view : https://github.com/exult/exult/compare/snapshot-v1.7.0.20210224
[01:45:29] travis-ci: Build details : https://travis-ci.com/exult/exult/builds/218042457
[11:19:46] travis-ci: flamewing/exult#1 (patch-1 - b54c45e : flamewing): The build passed.
[11:19:46] travis-ci: Change view : https://github.com/flamewing/exult/compare/91099ac985e8...b54c45e88e25
[11:19:46] travis-ci: Build details : https://travis-ci.com/flamewing/exult/builds/218081816
[12:26:20] travis-ci: exult/exult#559 (snapshot-v1.7.0.20210222 - 774debe : Marzo Sette Torres Junior): The build passed.
[12:26:20] travis-ci: Change view : https://github.com/exult/exult/compare/snapshot-v1.7.0.20210222
[12:26:20] travis-ci: Build details : https://travis-ci.com/exult/exult/builds/218087571
[18:18:41] Dominus: Marzo: we have looping digital music crashes :(
[18:19:22] Dominus: New BG game, go into stables and when the music starts the second time it crashes
[18:36:19] Dominus: backtrace https://pastebin.com/5f1srTAz
[18:43:33] Marzo: can you print in GDB the values of decomp and info?
[18:50:13] Dominus: how do I do that?
[18:51:23] Marzo: p decompenter:
[18:51:32] Marzo: p infoenter:
[18:52:47] Dominus: p info
[18:52:47] Dominus: (vorbis_info *) $15 = 0x0000000000000000
[18:53:11] Dominus: deco,p gives me error: Couldn't materialize: couldn't get the value of variable decomp: no location, value may have been optimized out
[18:53:11] Dominus: error: errored out in DoExecute, couldn't PrepareToExecuteJITExpression
[18:53:27] Dominus: but I used --with-optimization=debug
[18:53:54] Marzo: This can hapen if the value is in a register
[18:54:18] Marzo: Nevertheless, it already was enough to reveal that the problem is in info
[18:54:32] Marzo: For some reason, ov_info returned a null pointer
[18:56:19] Marzo: Can you also do p decomp->ov
[18:56:30] Marzo: Although it probably won work either
[18:56:48] Dominus: yes, doesn't work
[20:06:08] Dominus: if it helps: my snapshot from the 4th of February a06548fe still works, while 093d1a2a from the 7th crashes
[20:08:00] Dominus: and 093d1a2a is the only one touching anything in Audio
[20:12:32] Dominus: nah, it's crashing with the one before that, too
[20:12:45] Dominus: I'm doing a little regression test
[20:27:47] Dominus: Marzo: 2fa3ded3 is the culprit
[21:00:05] Dominus: Marzo: two other things I want to get your opinion:
[21:00:56] Dominus: - should I move mockup/smooth in a subfolder of tools when installed via the innosetup script?
[21:01:15] Marzo: Is there anyone actually using them?
[21:01:19] Dominus: with their files they might be better off with a joined subfolder
[21:01:30] Dominus: probably not
[21:02:07] Dominus: the other thing is whether you think it's fruitfull to make windows installers for our three mods
[21:02:40] Marzo: Maybe one installer for all 3
[21:03:01] Dominus: with the tools at hand we could easily query the location of BG and SI have the installer put them in the correct folder
[21:03:10] Dominus: true all three installer sounds good
[21:03:23] Marzo: We could use exconfig.dll to detect the base game and install them to the right places
[21:03:41] Dominus: yes, I was thinking that, too
[21:03:51] Marzo: And maybe import the verifier into exconfig.dll to make sure the games are not broken
[21:04:30] Marzo: I do remember how hard it was to get people to understand that you should just create a folder named ¨mods¨ at the same folder as ¨static¨ and extract the mods there
[21:04:44] Dominus: *was*?
[21:04:50] Dominus: it's still hard :)
[21:09:03] Dominus: but yes, the verifier would be good to have, as we need to ensure people have installed FOV and SS instead of the plain games (need to look into the Exult installer script and exconfig.dll if we can already differ between those)
[21:51:15] Marzo: Dominus: so, any interest in lip-synching the Guardian in BG intro? :-p
[21:52:27] Marzo: For German BG, I mean
[22:00:14] Marzo: Hm. Midi music seems to be hanging on the last note if they do not repeat
[22:00:34] Marzo: Can you use your builds to see if you can trace the origin?
[22:04:19] Dominus: hmm, I can try.
[22:04:46] Marzo: The music that plays right after the first scene in BG is short enough for the test
[22:05:54] Dominus: right
[22:07:37] Dominus: as for lip syncing, any plans to have that de-hardcoded?The German fan translation is doing a new voice over on BG and it's adding German voices to SI
[22:07:41] Marzo: Crash fixed
[22:08:11] Dominus: (the SI part is now finished and I need to prepare a new SIintro.dat for Sir John who does the translation)
[22:10:43] Marzo: What is hard-coded from lip synch is the surfacing data (when the guardian is popping out of the static); everything else comes from mainshp.flx object 0xf (15)
[22:12:15] Dominus: hmm, I know I had that hanging note but it's not happening now for me
[22:13:39] Marzo: I guess I should document the format of the lipsynch data so people can play with it without having to read the code
[22:14:22] Dominus: DAMNIT!!! again foiled by the digital driver being enabled while trying to play midi....
[22:14:30] Marzo: :)
[22:14:45] Marzo: Maybe we should combine those options
[22:15:16] Dominus: They were combined in older times ;)
[22:15:17] Marzo: Have a single toggle button that rotates through `digital music` and all midi types
[22:15:56] Dominus: But maybe the midi drivers should be blended out when the digital music is enabled
[22:19:31] Dominus: ok, I'm seriously not getting the hanging note anymore
[22:32:48] Dominus: Marzo: I get the hanging note on the scripted scene intro with FMOpl, but not Coreaudio midi
[22:33:10] Marzo: Hm, interesting
[22:33:24] Marzo: I get it with Windows audio, as well as fmopl
[22:34:51] Marzo: But finding out fmopl may help with both
[22:35:43] Dominus: Yes, I'll try my snapshots now with fmopl
[22:37:49] Dominus: The further you go back the more annoying bugs you run into that are now fixed
[22:39:51] Dominus: bah... my old builds do not display anymore :)
[22:40:44] Dominus: everything with an old SDL 1.2 doesn't display on my modern macos anymore...
[22:40:57] Dominus: but fear not... I have my buildbot :)
[22:48:38] Dominus: Marzo: it's already present in 2013
[22:48:46] Marzo: O>o
[22:51:04] Dominus: and in december 2010
[22:57:15] Dominus: and in october 2010
[22:57:35] Dominus: marzo, my guess is that it was introduced with the abolishing of SDL_mixer
[22:57:46] Marzo: Huh
[23:00:03] Dominus: and my oldest working snapshot is from august 2010
[23:01:36] Dominus: ha! found an old Windows snapshot from october 2009!
[23:08:10] Dominus: no frigging way...
[23:08:32] Dominus: marzo, it's also present in the ages old october 2009 snapshot of exult
[23:08:41] Marzo: Wow
[23:09:02] Marzo: Shows how little people have been using midi music
[23:09:17] Dominus: but I'm not sure whether it is only with the starting song
[23:09:33] Dominus: and looping had been standard for a while now
[23:12:05] Marzo: Hm. We can try in sound test with nonlooping music
[23:12:31] Marzo: Anyway, lipsynch data documented
[23:13:39] Dominus: so, in Exult 1.2 this hanging note is NOT present :)
[23:13:41] Marzo: And writing it up, I finally understood some patterns I had missed before
[23:15:40] Dominus: so the bug only manifested in between june 2004 and October 2010 :)
[23:17:16] Marzo: By the way, I am planning to make a final push on #ifdef stuff crossing statements, then reformat the entire codebase using the .clang-format file I have on the source code
[23:17:22] Marzo: Or maybe with a small tweak of it
[23:17:41] Dominus: that sounds painful
[23:17:54] Marzo: Abd then, I will enable a clang-tidy check for single statements not surrounded by braces and fix them all
[23:18:49] Marzo: And after *that*, I will add clang-tidy and clang-format checks to pull requests, and a pull-request generator that will generate pull requests to fix formatting issues
[23:19:38] Marzo: It should be relatively painless, because I have been going through #ifdefs for quite some time and removing them when opssible, and avoiding crossing statements with them as much as possible
[23:20:57] Marzo: Anyway, off to bed now
[23:21:46] Dominus: sleep well
[23:21:56] Dominus: thanks for fixing that bug
[23:25:03] Marzo: Tomorrow it will be automated Sourceforge webspace update after push to exult-web, and automated snapshot upload to Sourceforge webspace in addition to Github release
[23:25:23] Dominus: oooh
[23:25:43] Dominus: seems I need to clean up the exult web repository :)
[23:29:57] Dominus: aehm... audio tester only plays digital music tracks for me...
[23:49:18] Dominus: huh... that sound tester only working with the digital files might be just as old an bug
[23:54:57] Dominus: hmm, later tracks work...