[01:39:52] github-actions: exult/refs/pull/191/merge bad769b0594c34069ab050e4781af13f6dc01c20 https://github.com/exult/exult/actions/runs/2223461071 The Linux build succeeded.
[01:40:30] github-actions: exult/refs/pull/191/merge bad769b0594c34069ab050e4781af13f6dc01c20 https://github.com/exult/exult/actions/runs/2223461062 The Windows build succeeded.
[01:46:47] github-actions: exult/refs/pull/191/merge bad769b0594c34069ab050e4781af13f6dc01c20 https://github.com/exult/exult/actions/runs/2223461065 The Mac OSX build succeeded.
[01:53:28] github-actions: exult/refs/pull/201/merge 217f9626839621766ed12d582c71a216f894bf0d https://github.com/exult/exult/actions/runs/2223514607 The Windows build succeeded.
[01:54:19] github-actions: exult/refs/pull/201/merge 217f9626839621766ed12d582c71a216f894bf0d https://github.com/exult/exult/actions/runs/2223514603 The Linux build succeeded.
[01:54:28] github-actions: exult/refs/pull/200/merge 38b7ec2ab4fd1e374f7c475a291e417de4727c94 https://github.com/exult/exult/actions/runs/2223513393 The Linux build succeeded.
[01:55:01] github-actions: exult/refs/pull/200/merge 38b7ec2ab4fd1e374f7c475a291e417de4727c94 https://github.com/exult/exult/actions/runs/2223513401 The Windows build succeeded.
[02:00:41] github-actions: exult/refs/pull/201/merge 217f9626839621766ed12d582c71a216f894bf0d https://github.com/exult/exult/actions/runs/2223514606 The Mac OSX build succeeded.
[02:01:53] github-actions: exult/refs/pull/200/merge 38b7ec2ab4fd1e374f7c475a291e417de4727c94 https://github.com/exult/exult/actions/runs/2223513394 The Mac OSX build succeeded.
[02:05:00] github-actions: exult/refs/pull/200/merge 0a1bb2e7ae9ff9b59fefcfe115965ca9aaf185b6 https://github.com/exult/exult/actions/runs/2223549165 The Linux build succeeded.
[02:05:48] github-actions: exult/refs/pull/200/merge 0a1bb2e7ae9ff9b59fefcfe115965ca9aaf185b6 https://github.com/exult/exult/actions/runs/2223549166 The Windows build succeeded.
[02:11:23] github-actions: exult/refs/pull/200/merge 0a1bb2e7ae9ff9b59fefcfe115965ca9aaf185b6 https://github.com/exult/exult/actions/runs/2223549164 The Mac OSX build succeeded.
[06:13:55] github-actions: exult/refs/pull/191/merge 0c97b96656c91b92fb986eb86c085084158606ca https://github.com/exult/exult/actions/runs/2224338684 The Linux build succeeded.
[06:18:58] github-actions: exult/refs/pull/191/merge 0c97b96656c91b92fb986eb86c085084158606ca https://github.com/exult/exult/actions/runs/2224338690 The Mac OSX build succeeded.
[17:36:08] Krusher: hey hello
[17:57:30] Dominus: hey Krusher
[18:03:15] Dominus: Marzo: yes, probably time to switch to cmake. I had my misgivings about doing away with the iOS xcode project but in *theory* it could be possible to use the Android exult-as-a-lib and thus make it work. But that would be a lot to wrap my head around.
[21:07:24] github-actions: exult/refs/heads/master 851ca3880041e9a5253bd7784e1a4c00cffdab2e https://github.com/exult/exult/actions/runs/2228760004 The Windows build succeeded.
[21:10:34] github-actions: exult/refs/heads/master 851ca3880041e9a5253bd7784e1a4c00cffdab2e https://github.com/exult/exult/actions/runs/2228759982 The Linux build succeeded.
[21:16:12] github-actions: exult/refs/heads/master 851ca3880041e9a5253bd7784e1a4c00cffdab2e https://github.com/exult/exult/actions/runs/2228759975 The Mac OSX build succeeded.
[21:25:40] github-actions: exult/refs/heads/master 263403192d7ed7345cd97c1b281cd813bbc487a7 https://github.com/exult/exult/actions/runs/2228807389 The Mac OSX build succeeded.
[21:30:46] Dominus: curios... the whole placing of the sdlrwop stuff in the makefile.am and makefile.common files is off
[21:31:15] Dominus: I'll create a patch and will query cecka whether it needs to be this way
[21:42:43] Dominus: Marzo: if I add -Wno-portability to the "automake --add-missing --copy --gnu" line in autogen.sh I silence the "non-POSIX variable name" warning during autogen
[21:43:16] Dominus: see macos' https://github.com/exult/exult/runs/6181754521?check_suite_focus=true#step:4:18 and android's https://github.com/exult/exult/runs/6181754521?check_suite_focus=true#step:4:37
[21:45:41] Dominus: the only other way to get rid of these is to define those in configure and use AC_SUBST to replace them in the makefile.am files. not very pretty and obfuscates the makefile.am files
[21:47:14] Marzo: What happens if you replace the '$(shell pwd)' by '$(abs_top_srcdir)/macosx'
[21:49:54] Dominus: same warning: eval export SOURCE=$(abs_top_srcdir: non-POSIX variable name
[21:52:24] Marzo: Lets do it differently
[21:53:52] Marzo: Try this instead: https://pastebin.com/BrUc0FMY
[21:54:56] Dominus: same warning
[21:55:34] Dominus: marzo, sorry, no that fixed it, I made am istake
[21:55:37] Marzo: Try with top_srcdir instead of abs_top_srcdir
[21:55:42] Marzo: Ah, ok
[21:55:44] Marzo: Good
[21:56:01] Marzo: Now for the android one
[21:57:14] Dominus: another question, as I noticed, the "studiobundle: $(EXE_TARGET)" is actually wrong. the studiobundle is not dependend on the EXE_TARGET, but on the exult_studio binary in mapedit. I couldn't find a way to set that (and should at least remove the EXE_TARGET)
[21:59:54] Marzo: Probably should use $(top_srcdir)/mapedit/exult_studio$(EXEEXT) instead
[22:00:36] Marzo: Or better, look at how data/Makefile.am handles the expack dependency and do likewise
[22:01:31] Dominus: good pointer
[22:04:20] Dominus: marzo, that other fix for macosx doesn't actually set the SOURCE variable to be used for the gtkmacbundler this way
[22:04:56] Marzo: Hm
[22:05:27] Marzo: Try instead prepending SOURCE=$(abs_top_srcdir)/macosx to the gtk-mac-bundler line
[22:15:08] Dominus: that seems to work (but I need just SOURCE=$(abs_top_srcdir) as the bundlerfile macosx/exult_studio.bundle really needs the top of the source
[22:15:37] Dominus: it ran through and that works
[22:15:43] Marzo: Perfect
[22:15:51] Dominus: SOURCE=$(abs_top_srcdir) gtk-mac-bundler ./macosx/exult_studio.bundle
[22:32:03] Marzo: The pathsubst ones I don't see how to solve without expanding them in configure.ac
[22:32:24] Marzo: Or requiring the use of gmake instead of make on iOS/BSD
[22:32:52] Dominus: ugh
[22:37:44] Marzo: The issues being that (1) the function call syntax used is a non-POSIX GNU extension, (2) there is no direct to pathsubst equivalent in BSD make, (3) the closest equivalent thing in BSD make (which has a shared syntax in GNU and BSD makes) does not accept % as a wildcard
[22:38:37] Marzo: So options are doing it automatically in configure.ac, hard-coding the results directly in Makefile.am, or doing it automatically in Makefile.am and requiring GNU make
[22:39:38] Dominus: gnu make requirement is not really an option, IMO
[22:41:00] Dominus: none of those options are very pretty :(
[22:56:11] Marzo: Oh, wait
[22:59:46] Marzo: Hm, nevermind, still won't work because of $(wildcard ...)
[23:06:41] Marzo: Dominus: I think that this would work, and is the closest we can get: https://pastebin.com/d0WQqi70
[23:08:30] Marzo: The syntax used in APK_ASSETS is defined to work like the patsubst in GNU make, and it has a special clause for BSD make for % which should make it do the same thing
[23:10:53] Marzo: Ah, but nevermind
[23:11:57] Marzo: Just realized all the other GNU make stuff on there
[23:19:55] Dominus: yeah, the [ and dir $@
[23:20:06] Dominus: the %
[23:23:37] Marzo: I think that the apk assets may be overpacked; isn't bg_paperdol.vga and bg_mr_faces.vga packed inside exult_bg.flx?
[23:24:07] Dominus: yes, now that you mention it
[23:24:47] Dominus: and what is u7misc.data?
[23:25:13] Marzo: Those *.data files are used by ucxt, IIRC
[23:25:16] Dominus: ah, from ucxt
[23:25:28] Dominus: and don't need to be in the apk as well
[23:25:48] Marzo: Agreed
[23:26:30] Marzo: Only 5 files will remain on the list, I think
[23:27:16] Marzo: And most of the $(APK_ASSETS_DIR)/% rules can go away after that
[23:27:35] Dominus: only the flx, exultmsg.txt is also bundled
[23:27:41] Dominus: so only 4 files
[23:27:53] Marzo: Ah, true
[23:28:04] Dominus: (and one could argue about the midisfx.flx)
[23:29:10] Marzo: midisfx.flx needs support to be compiled into Exult
[23:29:17] Marzo: Which is not done by default
[23:30:23] Dominus: that needs to be a question for cecka, does the Android port even play midi?
[23:32:28] Marzo: No clue