Very small dialogue bug

NOTICE: This forum is archived as read only.
Please use the Github Discussions at https://github.com/exult/exult/discussions
Forum rules
NOTICE: This forum is archived as read only.
Please use the Github Discussions at https://github.com/exult/exult/discussions
Locked
Peter Olafson

Very small dialogue bug

Post by Peter Olafson »

I think this one goes back some ways.

As I read the usecode file (imperfectly, I'm sure), eating garlic as a food should be rewarded with a unique comment ("Yum, garlic!”). But I've never seen this response under ExUlt (and IU'm not sure whether I saw it in THG under DOS, either).

Just puttin' it out there. :)

Peter
drcode
Site Admin
Posts: 2267
Joined: Thu May 14, 2020 1:34 pm

Re: Very small dialogue bug

Post by drcode »

I don't recall seeing it in the original, either.
marzo
Site Admin
Posts: 1925
Joined: Thu May 14, 2020 1:34 pm

Re: Very small dialogue bug

Post by marzo »

It is yet another usecode bug. According to the usecode, the "@Yum, garlic!@" message was supposed to appear in two conditions:
(1) if the current food level is 20;
(2) if the current food level is < 20.
Condition (1) is impossible to be fulfilled because garlic only adds 2 to food level; condition (2) is made void because there is no branch after the message is set to "@Yum, garlic!@", and it is immediately set to "@Ahh, very tasty.@" afterward (and may be set to "@Belch@" under some conditions).
------
Marzo Sette Torres Junior
aka Geometrodynamic Dragon
[url=http://www.catb.org/~esr/faqs/smart-questions.html]How To Ask Questions The Smart Way[/url]
TdI

Re: Very small dialogue bug

Post by TdI »

Wow, after so many years, still I am discovering new, fascinating Ultima VII content. Yum, garlic!
marzo
Site Admin
Posts: 1925
Joined: Thu May 14, 2020 1:34 pm

Re: Very small dialogue bug

Post by marzo »

I forgot to mention that the Quests & Iterations mod (consequently, Keyring and TFL mods) fix this particular issue.
------
Marzo Sette Torres Junior
aka Geometrodynamic Dragon
[url=http://www.catb.org/~esr/faqs/smart-questions.html]How To Ask Questions The Smart Way[/url]
Tobyn

Re: Very small dialogue bug

Post by Tobyn »

sorry to bother again, but I still get the strange stealing msgs and one nice pikeman for *each* eaten garlic, even *own* garlics...

Avatar: "Ahh, tasty"
party: "Avatar?!?" ... "must we do this" ... "is that virtuous?" ... "I am leaving"
pikeman: "cease and desist immediately"

Needless to say, this is BlackGate with latest Exult snapshot, with and without latest keyring. I already reported this for earlier snapshots a few weeks ago (although in the "water walking" thread *g*) and at least now the 2 food points are added to food level, but still...
Peter Olafson

Re: Very small dialogue bug

Post by Peter Olafson »

Marzo,

Just a guess, but could it be that, in (1), "20" should have been "2"?

Peter
marzo
Site Admin
Posts: 1925
Joined: Thu May 14, 2020 1:34 pm

Re: Very small dialogue bug

Post by marzo »

Just a guess, but could it be that, in (1), "20" should have been "2"?
It would still be impossible to fulfill the condition this way -- the new food level decreasing because you *ate* something? It could be that the last check should be omitted, or maybe a check for a random value; but it is not what the usecode is right now.
------
Marzo Sette Torres Junior
aka Geometrodynamic Dragon
[url=http://www.catb.org/~esr/faqs/smart-questions.html]How To Ask Questions The Smart Way[/url]
Andrea B Previtera

Re: Very small dialogue bug

Post by Andrea B Previtera »

What you say about the usecode is absolutely undeniable but at the same time there's something strange going on! Maybe there were more versions of U7 out there, with slightly different data files?

Because, indeed, I and my friends encountered the "Yum, garlic!" message while playing the original. Infact, I also clearly remember that when we noticed this peculiarity we tried every single other food to check out if there were other specific messages.

This is not the first time, too, that I read usecode discussions stating that something was left out/disabled/hidden/impossible/broken - but instead I saw it happening in the original.
marzo
Site Admin
Posts: 1925
Joined: Thu May 14, 2020 1:34 pm

Re: Very small dialogue bug

Post by marzo »

I checked only the FoV (Ultima Collection CD) version; it could be that they broke it in that version (and I actually checked under DOSBox first, I looked in the usecode when I couldn't get it to show up). It seems that SS also has the same issue.
------
Marzo Sette Torres Junior
aka Geometrodynamic Dragon
[url=http://www.catb.org/~esr/faqs/smart-questions.html]How To Ask Questions The Smart Way[/url]
Salicias

Re: Very small dialogue bug

Post by Salicias »

>(1) if the current food level is 20

>Just a guess, but could it be that, in (1), "20" should have been "2"?

The way it is written above, (I haven't seen the usecode) a current amount of 1, 2, 3 or 4 would trigger this if the garlic gives 2 points.

Example: Current value of 2 (less than or equal to 4) + 2 (garlic) = 6 (greater than 2).

Or is this one beer I just had making me not do math right???
marzo
Site Admin
Posts: 1925
Joined: Thu May 14, 2020 1:34 pm

Re: Very small dialogue bug

Post by marzo »

Or is this one beer I just had making me not do math right???
Hm. No, you are correct, it *is* possible to fulfill the condition if the new food level check were for 2 instead of 20. I wonder what I was thinking when I wrote otherwise?
------
Marzo Sette Torres Junior
aka Geometrodynamic Dragon
[url=http://www.catb.org/~esr/faqs/smart-questions.html]How To Ask Questions The Smart Way[/url]
Locked