Please add the Exult PPA to the Downloads Page

NOTICE: This forum is archived as read only.
Please use the Github Discussions at https://github.com/exult/exult/discussions
Forum rules
NOTICE: This forum is archived as read only.
Please use the Github Discussions at https://github.com/exult/exult/discussions
Dominus
Site Admin
Posts: 5656
Joined: Thu May 14, 2020 1:34 pm

Re: Please add the Exult PPA to the Downloads Page

Post by Dominus »

Are you sure there is everything ok with your system?
And can you show us your diff and the makefile when it complains about the seperator?
It is working on Os X and a fedore vm I have.
--
Read the documentation and the FAQ! There is no excuse for not reading them! RTFM
Read the Rules!
We do not support Piracy/Abandonware/Warez!
paulo

Re: Please add the Exult PPA to the Downloads Page

Post by paulo »

Ok, starting from scratch in a single step since you're not convinced (for some reason):



$ automake --version
automake (GNU automake) 1.12.6
(newer than 1.12.0, which introduced the incompatibility)


first off, copy pasting the patch posted here doesn't actually work, probably because of line endings:
patch: **** malformed patch at line 13: uclex.o: uclex.cc ucparse.h

whatever, i just copy paste the 3 lines added, into the Makefile.am at the right location, and delete the 3 '+'.
$ bzr checkout --lightweight lp:exult-engine exult_test
$ gedit exult_test/usecode/compiler/Makefile.am &
$ cd exult_test
$ ./autogen.sh && ./configure --enable-compiler --enable-all-hq-scalers=no --enable-nxbr=no && make

and it ends in error (of course):
make[3]: Leaving directory `/home/paulo/Documents/Netbeans_projects/exult_test/usecode'
Making all in compiler
make[3]: Entering directory `/home/paulo/Documents/Netbeans_projects/exult_test/usecode/compiler'
Makefile:669: *** missing separator. Stop.
make[3]: Leaving directory `/home/paulo/Documents/Netbeans_projects/exult_test/usecode/compiler'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/paulo/Documents/Netbeans_projects/exult_test/usecode'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/paulo/Documents/Netbeans_projects/exult_test'
make: *** [all] Error 2

adding the $(SHELL) thing to the right line, and retrying that last shell line:
$ ./autogen.sh && ./configure --enable-compiler --enable-all-hq-scalers=no --enable-nxbr=no && make
make[3]: Nothing to be done for `all-am'.
make[3]: Leaving directory `/home/paulo/Documents/Netbeans_projects/exult_test/usecode'
Making all in compiler
make[3]: Entering directory `/home/paulo/Documents/Netbeans_projects/exult_test/usecode/compiler'
Makefile:669: *** missing separator. Stop.

same error. If i _add_ the seperator '\' that the 'ucparse.h' rule is complaining about, i get, the other, different error that i posted here:
$ ./autogen.sh && ./configure --enable-compiler --enable-all-hq-scalers=no --enable-nxbr=no && make
/bin/bash ../../ylwrap uclex.ll lex.yy.c uclex.cc -- flex
make[3]: *** No rule to make target `test', needed by `ucparse.h'. Stop.
make[3]: Leaving directory `/home/paulo/Documents/Netbeans_projects/exult_test/usecode/compiler'

(curiously, this is still with the $(SHELL) variant, so it seems this variable is expanding to a empty string)

So there you have it, it may be working on fedora, but it's certainly not working on ubuntu.
I don't need the fix upstream anymore since i'm applying that other patch i did for the builds so as far as i'm concerned you can keep things as they are and just change .h for .hh when automake < 1.12 is no longer supported.
Dominus
Site Admin
Posts: 5656
Joined: Thu May 14, 2020 1:34 pm

Re: Please add the Exult PPA to the Downloads Page

Post by Dominus »

http://stackoverflow.com/questions/1312 ... rator-stop
Tab vs spaces for the the test command, I guess
--
Read the documentation and the FAQ! There is no excuse for not reading them! RTFM
Read the Rules!
We do not support Piracy/Abandonware/Warez!
paulo

Re: Please add the Exult PPA to the Downloads Page

Post by paulo »

all right, it worked with a tab instead of spaces (gedit was replacing tabs by spaces, even when writing manually).
When and if you apply it i will remove the patch from the the ppa repo.

$(SHELL) as was said, is not needed.
Dominus
Site Admin
Posts: 5656
Joined: Thu May 14, 2020 1:34 pm

Re: Please add the Exult PPA to the Downloads Page

Post by Dominus »

Yeah, simple research helped ;)
--
Read the documentation and the FAQ! There is no excuse for not reading them! RTFM
Read the Rules!
We do not support Piracy/Abandonware/Warez!
Locked