Exult Forum

Just to make things clear: I've finally found some time to fiddle around with Exult's code.
At the moment I going through the bugtracker, for example I think I managed to implement a fix for this one:
https://sourceforge.net/p/exult/bugs/1936/
What should I do in such case? Register on SF and provide a patch as an attachment?

If I haven't RTFMed enough then sorry for introducing mess here, just please point me to the right place

BTW, nice to see the project still alive after all these years.

Thanks a lot!
Best would be if you make a sourceforge account and provide a patch. That is how we used to operate.
But since we moved the code to Github, a pull request is probably as welcome. We haven't really established "rules" for this since the move to github
So for now, either is fine

Ok, done.

BTW, pull requests seem much more "gitish" (and thus consistent with the whole repo) way, I think I'll try those when commiting next code (unless you'll prefer it otherwise).

Have a nice weekend

Thanks again! I guess we will need to try things out and see what we prefer in the end. So yes, please do a pull request next time, so we can decide
But I don't see any problem either way. With a patch we have it stored with the bug, and need to apply it and then close the bug with a commit reference.
With a pull request (that links to the bug) we need to merge and close the bug report with a commit reference...
Merge might be nicer since ut properly references your contribution and points at your fork.

+1 on Pull Requests