Page 1 of 1

Bug when saving a game, i think.

Posted: Thu Jan 24, 2019 4:57 pm
by Nickisaacson
In Exult when you go to save a game, you add a description. If you use the 10-key part of the keyboard (to add the date), then it adds some extra characters.

The game will still save, but the description will be confusing.

Re: Bug when saving a game, i think.

Posted: Fri Jan 25, 2019 5:07 am
by Knight Captain
Seeing the same thing, using one version behind on Windows 10.

It looks to be related to the NumLock key, since with NumLock off you don't get anything but the unintended character. Yet if you have NumLock on you get both the unintended and intended character.

https://sourceforge.net/p/exult/bugs/2035/

Re: Bug when saving a game, i think.

Posted: Fri Jan 25, 2019 8:19 am
by Dominus
It's a regression of the switch to SDL2. Old SDL1.2 builds still work as expected. Maybe I can figure it out.

Re: Bug when saving a game, i think.

Posted: Fri Jan 25, 2019 7:47 pm
by Nickisaacson
Glad to help folks!

Re: Bug when saving a game, i think.

Posted: Sat Jan 26, 2019 11:55 pm
by Dominus
So, Marzo fixed it in a development branch and as soon as some other bugs of that branch are fixed it is going to be merged into the master branch and will be available as a snapshot (along with the notebook gump).
Thanks for bringing this to our attention!

Re: Bug when saving a game, i think.

Posted: Sun Jan 27, 2019 12:36 am
by Knight Captain
Does that include ye olde Studio?

Re: Bug when saving a game, i think.

Posted: Sun Jan 27, 2019 3:44 am
by Dominus
Yes ;)

Re: Bug when saving a game, i think.

Posted: Sun Jan 27, 2019 9:52 am
by Gotcha!
Lots of thanks to all involved. :)

Re: Bug when saving a game, i think.

Posted: Sun Jan 27, 2019 1:04 pm
by Dominus
and panning the map via the mousewheel as well as scrolling the savegame list and sliders is also fixed.
SDL 1.2x recognized mousewheel as button 4 and 5 events while SDL2 actually recognizes the mousewheel itself. So the SDL 1.2x code did not do anything at all on SDL2.
But also only in the experimental branch which has no snapshots yet.