UI_close_gumps not working?

[agentorangeguy]

anyone else having trouble with getting the UI_close_gumps(); intrinsic working?? it doesn't appear to do anything anymore

[agentorangeguy]

I'm trying to make a usecode egg with "something on", that once you remove the object on the egg, or put something on it, all gumps should close.

In the past this has worked, but now it doesn't...?

the DOUBLECLICK event seems to work if you use UI_close_gumps but the EGG event doesn't seem to?

[Dominus]

Hmm, I'm triyibg to think of an in game egg like this. I know there is one but right now I cannot remember.
And probably needs a mod to test it, too, so I can do a regression test.

[agentorangeguy]

Try the egg in front of Penumbra's house maybe? in U7

[Dominus]

well, at least that is working. Take a look at the keyring mod, there are some UI_close_gumps in there. Mostly doubleclick but some are Scripted maybe that helps.
KnightCaptain to the rescue?

[agentorangeguy]

They should work up on EGG event too, they used to. One of the eggs I had for my mod for an egg triggered by "Something On" used to close the gumps when it was triggered, but it no longer does that.

[Dominus]

Can you give me pointers in how to implement that in a mid so I can see if I can reproduce it?

[agentorangeguy]

something basic like

Code: Select all

if (event == EGG)
{
    UI_close_gumps();


}

with the usecode egg set to "something on". If an object is on the egg and removed, it should activate the code, and it *should* close the gumps, but doesnt.

[Knight Captain]

Can you email me your function?

Also, what settings are you using in ES for the egg?

I'm always a fan of Usecode debug messages going to stdout.

[agentorangeguy]

ES settings for the egg:

Something On
probability 100
checked autoreset
Distance 1
Function number 0xbe8
quality 0

I can't seem to ever find where the stdout file goes to so I just use party barks when I need to make sure if something is working haha

Email sent with the code in question

[agentorangeguy]

anyone know whats up with it?

[Dominus]

I'll investigate after this little business trip

[Dominus]

I don't know if I did it correctly, but in the islandfaq mod, I changed usecode like this:

enum events
{
EGG = 0
};

//TEST usecode egg
void Somethingegg object#(0xbe8) ()
{
if (event == EGG)
{
UI_close_gumps();
}
}

And in Exult added an egg according to your instructions:
Something On
probability 100
checked autoreset
Distance 1
Function number 0xbe8
quality 0

But it's not triggering as far back as my snpashots archive of 2012. So I think either I'm doing it wrong, or ucc changed and the resulting usecode is broken, or this way of doing it wrong and that's why it isn't working for you.
I'll see if Marzo can chime in.

[Knight Captain]

EGG should be 3, not 0.

https://github.com/exult/exult/blob/mas ... nstants.uc
https://github.com/exult/exult/blob/mas ... nstants.uc

[Dominus]

I don't think that matters when I just enumerate this

[Dominus]

I think I got on the right track.

It does work (I just needed to get rid of the if (event == EGG) otherwise it wouldn't trigger at all for me, but I guess that is due to some other usecode stuff, I'm just doing wrong.
So

Code: Select all

void Somethingegg object#(0xbe8) ()
{	
	    UI_close_gumps();
}

diid work (only needs to be sure that only Auto-reset is ticked, for some reasons it often ticked hatched when applying - And I used Distance 5 to make sure).

BUT (and there is always a but), you need to have set Gumps to not Pause the game in Gameplay settings.
That's very likely the culprit in your setup.

And again, I tested this with snapshots archive, this worked like this already in January 2012.

But in the original it works when gumps are open. So we might need to fix this.

[Knight Captain]

Event 0 is proximity, and I don't believe that triggers when Gumps are open.

Gumps pause the gameplay by default.

Nice bug find, Dominus!

[agentorangeguy]

Excellent, so i wasn't crazy haha.

I remember the egg from Penumbra's in the original closing all gumps when you'd place the object to give the sparkly effect. I just tried it and it didn't work as it should, so yeah something definitely had changed over the years and got broken

[Dominus]

I have now tracked down the culprit in the code but I don't understand it enough to fix it on my own.
It's got something to do with Gump_manager.cc:668 void Gump_manager::set_gumps_dont_pause_game(bool p)
if I comment the first two code lines, both states close the gumps. But I don't get what this code does to begin with

[agentorangeguy]

We must summon Marzo!

[Dominus]

Funny, it's a 17 years old bug, introduced when Colourless made it possible to use gumps and not have the game paused by that. So Exult 1.0 was still correct, but Exult 1.2 was already broken.
The commit that broke it https://github.com/exult/exult/commit/2 ... 0a8fb3a533

[Fretka Furlet]

@agentorangeguy: If you're running in Win 10, the stdout.txt and stderr.txt files are located in C:\Users\Appdata\Local\Exult, same place the savegame files are.

[agentorangeguy]

Any luck contacting Marzo , or Dr Code? or anyone who could fix this?

[Dominus]

No luck ;(

[drcode]

Sorry, I've been really busy lately. Is this related to a problem I'm seeing when playing, where I'll perform some action when gumps are open, like giving food, but nothing happens until I close the gumps?

[Dominus]

Most likely.
It's got something to do with Gump_manager.cc:668 void Gump_manager::set_gumps_dont_pause_game(bool p)

if I comment the first two code lines, both states close the gumps and then they don't. But I don't get what this code does to begin

[drcode]

I think set_gumps_dont_pause_game only gets called when you bring up the game options menu. The real problem is the 'dont_pause' feature (which defaults to 'no'), which means we pause everything when a gump is open. This is what has been bothering me while I've been playing lately.

And it's probably preventing usecode from running too, so the 'close_gumps' intrinsic doesn't get activated until after you close the gumps.

I'll try playing with 'dont_pause' set to 'yes'.

[agentorangeguy]

Any luck with this, Dr Code?

[drcode]

Try this in your exult.cfg:


...

yes

[Dominus]

I might have solved this finally https://github.com/exult/exult/issues/153

[Dominus]

And it's in the code. Marzo confirmed my findings.