Thanks, and some bugs...

NOTICE: This forum is archived as read only.
Please use the Github Discussions at https://github.com/exult/exult/discussions
Forum rules
NOTICE: This forum is archived as read only.
Please use the Github Discussions at https://github.com/exult/exult/discussions
Locked
MagicMop
Posts: 68
Joined: Thu May 14, 2020 1:34 pm

Thanks, and some bugs...

Post by MagicMop »

Fistly, I want to say a BIG THANKYOU to the Exult team for doing an incredible job. You've actually improved one of the best games ever made!

I've just played through the Black Gate using a new game from the beta release - heaps of fun! I found a few little bugs, but nothing serious. I'll list them here if it'll help at all:

1. Between 12 and 1 o clock in the afternoon, the time is listed as 'am' not 'pm'

2. In the Meditation Retreat there were 2 Gorns - Though only one could be talked to.

3. The wisps attacked me for no reason when I first encountered them. Actually, I seem to recall this happening in the original too. I could still chat to them with the whistle though, so that was okay... I just spent a lot of time in the forests running away... ;)

4. When I returned the notebook, Alagner wasn't dead... he was still happily wandering around... the crystal ball showed him being beaten by E&A though. The funny thing is, I walked out of the building, and then back in, and there he was in peices on the floor.

5. The game crashed when I tried to enchant my bolts and arrows. Worked the second try though.

6. After I had successfully enchanted my arrows, the game wouldn't save... it would just crash to the desktop. I fixed this by going back to a previous save. Don't know if it had anything to do with enchant - I didn't try that spell again though...

7. My companions seem to be able to set off teleporters. There was one place on ther Isle of the Avatar where I bounced back and forth on a teleporter 'cause my party kept stepping on it... ;)

That's it. Like I said... nothing too serious. Oh... and if you're interested, I'm running on WinXP and have been updating the beta with the latest snapshots whenever they are released.

Thanks again for resurrecting such a classic. You guys are champions!!

MM
Stephan

Re: Thanks, and some bugs...

Post by Stephan »

Alagner has always been buggy, even in the original BG. He has a habit of walkinga round on his own mutilated corpse from time to time.
Max aka Moscow Dragon

Re: Thanks, and some bugs...

Post by Max aka Moscow Dragon »

>Between 12 and 1 o clock in the afternoon, the time is listed as 'am'
>not 'pm'

On the pocketwatch?

The usecode opcode for comparison for sure.
Surely it can cause LOTS of other bugs in all places.
wjp
Site Admin
Posts: 1708
Joined: Thu May 14, 2020 1:34 pm

Re: Thanks, and some bugs...

Post by wjp »

The usecode for the pocketwatch is buggy. This should be happening in the original too.
drcode
Site Admin
Posts: 2267
Joined: Thu May 14, 2020 1:34 pm

Re: Thanks, and some bugs...

Post by drcode »

That's true. They fixed the am/pm bug in SI's usecode.

I'm most interested in the crash when you enchanted the arrows. Were the arrows on the ground, in a backpack, or on the paperdoll? I'd like to try to reproduce this tonight.

I'll also look into the teleporter bug.
Oblivious

Re: Thanks, and some bugs...

Post by Oblivious »

I have that problem with the two Gorns, as well. Also, there are two mayors of Skara Brae. And I use Win 98....
drcode
Site Admin
Posts: 2267
Joined: Thu May 14, 2020 1:34 pm

Re: Thanks, and some bugs...

Post by drcode »

I know how to fix the problem with the two mayors, and it might fix the two Gorns as well. But I'm not sure if I can do it without messing up savegames.

I just tried enchanting arrows, and couldn't get a crash:-(
MagicMop
Posts: 68
Joined: Thu May 14, 2020 1:34 pm

Re: Thanks, and some bugs...

Post by MagicMop »

Well... I just went back to my old savegame where it happened last time and enchanted every missle I could get my hands on. No crash. I tried saving... no crash again.

Perhaps the game got corrupted some other way? I can't reproduce it, so I guess it's not worth wasting time on. Sorry about that.

I'm about to start my first game of Serpent Isle since I played the original on my old 386 MANY years ago. Thanks a million for making it possible guys. I'll post any bugs when I finish it...

MM
Max aka Moscow Dragon

Re: Thanks, and some bugs...

Post by Max aka Moscow Dragon »

Yes, wjp, thanks, sorry for being over-worked yesterday and posting nonsense :-)

The usecode is the following (my manual decompile):

Time = GetTimeHour()
TimeName = "am"

If Time > 12 Then
Time = Time - 12
TimeName = "pm"
End If

If Time = 0 Then
Time = 12
TimeName = "am"
End If

This produces and incorrect result for 12PM. It will print 12AM instead.
artaxerxes
Site Admin
Posts: 1310
Joined: Thu May 14, 2020 1:34 pm

Re: Thanks, and some bugs...

Post by artaxerxes »

Methink the exult team should implement a 24 hour clock instead.

It is much easier to read than a 12 hour to my opinion (and it engages only my opinion).

I've always found the 12 hour clock thing to be wacked:

The hours go:
12, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11 for the morning

and
12, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11 for the afternoon.

I mean, couldn't it start at 1 or at 0 rather than at 12?

The 24 hour clock is much simpler. Start at 0. Every hour is different (no need to add am/pm ...)
0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23.

What do you think? Impossible to implement in exult?

Artaxerxes
wjp
Site Admin
Posts: 1708
Joined: Thu May 14, 2020 1:34 pm

Re: Thanks, and some bugs...

Post by wjp »

A small patch to the pocketwatch usecode function would do the trick. Jeff's usecode compiler might be able to produce it already. Feel free to give it a try :-)
Vigil

Re: Thanks, and some bugs...

Post by Vigil »

I presume it should be as follows:

Time = GetTimeHour()
TimeName = "am"

//catch 12 noon
If Time = 12 Then
TimeName = "pm"
End If

//catch midnight and set to 12am
If Time = 0 Then
Time = 12
End If

//set pm times
If Time > 12 Then
Time = Time - 12
TimeName = "pm"
End If

A 24-hour clock wouldn't be at all difficult, in fact it would just entail removing the above lines of code and printing the hour as-is. But on the other hand, not everyone is continental ;)
artaxerxes
Site Admin
Posts: 1310
Joined: Thu May 14, 2020 1:34 pm

Re: Thanks, and some bugs...

Post by artaxerxes »

Well, even the US army uses 24h clock!

;-)

Artaxerxes
Max aka Moscow Dragon

Re: Thanks, and some bugs...

Post by Max aka Moscow Dragon »

Or:

Time = GetTimeHour()
TimeName = "am"

If Time >= 12 Then
Time = Time - 12
TimeName = "pm"
End If

If Time = 0 Then Time = 12


Even simpler then the original.
artaxerxes
Site Admin
Posts: 1310
Joined: Thu May 14, 2020 1:34 pm

Re: Thanks, and some bugs...

Post by artaxerxes »

Or:

Time = GetTimeHour()
TimeName = ""

Artaxerxes
Locked