Black bars on map export

NOTICE: This forum is archived as read only.
Please use the Github Discussions at https://github.com/exult/exult/discussions
Forum rules
NOTICE: This forum is archived as read only.
Please use the Github Discussions at https://github.com/exult/exult/discussions
Locked
LordSkitch
Posts: 4
Joined: Thu May 14, 2020 1:34 pm

Black bars on map export

Post by LordSkitch »

I'm trying to make a full u7 map, and I noticed the images that are generated when you use the command "exult --fov --buildmap 0" happen to have a 172 pixel black bar at the top.

At first I assumed it was just some sort of padding and removed it, but when I assembled the images, I noticed data was missing, so it's actually where map data should be, its just being rendered solid black.

Here's a low-res example of an assembled map:

http://www.the-coming.com/images/blackBars.jpg

and a normal-res example of a single image:

http://www.the-coming.com/images/u7map00.png

I took a look at the code, in exult.cc at line 2342 there's a function called BuildGameMap, which just steps through every tile in every chunk, draws it to a buffer, and takes a screen shot. The only thing I can think is maybe the buffer isn't big enough or the screenshot function has an issue where it doesn't copy all the data, but I'm not familiar enough with the code to find out where it all is.

It might even be a configuration issue that I've overlooked... but I've run out of ideas.

Anyone have any clue as to a resolution for the black bar issue?

[Edit by Dominus: now that the problem is solved the images are linked and not shown]
Dominus
Site Admin
Posts: 5656
Joined: Thu May 14, 2020 1:34 pm

Re: Black bars on map export

Post by Dominus »

Sounds like a bug
--
Read the documentation and the FAQ! There is no excuse for not reading them! RTFM
Read the Rules!
We do not support Piracy/Abandonware/Warez!
Dominus
Site Admin
Posts: 5656
Joined: Thu May 14, 2020 1:34 pm

Re: Black bars on map export

Post by Dominus »

Unfortunately I was able to reproduce it :(
Seems it broke when we changed the scaler/filler thing some time ago...

I entered a bug report about it. Thanks for reporting it.

Edit:
the last good revision is #6332. It broke in one of the revisions that lead
to #6344 (since my snapshot collection has no snapshot in between these two
revisions).
--
Read the documentation and the FAQ! There is no excuse for not reading them! RTFM
Read the Rules!
We do not support Piracy/Abandonware/Warez!
Dominus
Site Admin
Posts: 5656
Joined: Thu May 14, 2020 1:34 pm

Re: Black bars on map export

Post by Dominus »

Marzo just fixed it!
--
Read the documentation and the FAQ! There is no excuse for not reading them! RTFM
Read the Rules!
We do not support Piracy/Abandonware/Warez!
LordSkitch
Posts: 4
Joined: Thu May 14, 2020 1:34 pm

Re: Black bars on map export

Post by LordSkitch »

I was intending on compiling the latest build to try it out... but after about an hour and a half of trying to find and get the various packages to get the environment set up correctly, I gave up. Visual Studio has obviously corrupted me. I'll just wait for the next snapshot lol.
Dominus
Site Admin
Posts: 5656
Joined: Thu May 14, 2020 1:34 pm

Re: Black bars on map export

Post by Dominus »

Newest snapshot already has the changes.
--
Read the documentation and the FAQ! There is no excuse for not reading them! RTFM
Read the Rules!
We do not support Piracy/Abandonware/Warez!
LordSkitch
Posts: 4
Joined: Thu May 14, 2020 1:34 pm

Re: Black bars on map export

Post by LordSkitch »

My god, you guys are badasses. I didn't realize it was an up to date build. Is there like a donate button or something I can donate to the project with?
Dominus
Site Admin
Posts: 5656
Joined: Thu May 14, 2020 1:34 pm

Re: Black bars on map export

Post by Dominus »

No, we can't/won't accept donations to give no ground to any potential lawsuit that EA might start (no one believes this will actually happen but we want to stay on the safe side). Anyway, snapshots are made daily/when there are changes to the code. Always check the date on the download page.
--
Read the documentation and the FAQ! There is no excuse for not reading them! RTFM
Read the Rules!
We do not support Piracy/Abandonware/Warez!
LordSkitch
Posts: 4
Joined: Thu May 14, 2020 1:34 pm

Re: Black bars on map export

Post by LordSkitch »

Well... hmm... how else can I help out? I'm a c# dev primarily these days, which doesn't help out you cross-platform guys very much. If you guys needed SharePoint on the other hand, that I could do!

My confusion for the builds seems to stem from Marzo accidentally putting the wrong date on it (2012-11-16 as opposed to 2012-12-06). If I had known, I'd have been flying through the air to hit the download link.

I'd buy you both a beer, were you in Texas!
Locked